Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate deregisterCriticalServiceAfter option #674

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

pschultz
Copy link
Member

The deregisterCriticalServiceAfter option applied to the HTTP health
check for services that are registered in Consul.

#664 introduced additional Consul TTL checks. These TTL
checks have DeregisterCriticalServiceAfter set to the minimum of one
minute and will therefore always beat or tie the HTTP check's
DeregisterCriticalServiceAfter option, rendering it obsolete.

Document this fact in the usage message and HTML docs.

The deregisterCriticalServiceAfter option applied to the HTTP health
check for services that are registered in Consul.

Commit ea3a365 introduced additional Consul TTL checks. These TTL
checks have DeregisterCriticalServiceAfter set to the minimum of one
minute and will therefore always beat or tie the HTTP check's
DeregisterCriticalServiceAfter option, rendering it obsolete.

Document this fact in the usage message and HTML docs.

Signed-off-by: Peter Schultz <peter.schultz@classmarkets.com>
@pschultz pschultz requested a review from aaronhurt July 15, 2019 13:38
Copy link
Member

@aaronhurt aaronhurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good minus the small comment on string concatentation. Thank you again.

registry/consul/register.go Show resolved Hide resolved
@aaronhurt
Copy link
Member

Re-running tests via Travis integration.

@aaronhurt aaronhurt closed this Jan 27, 2020
@aaronhurt aaronhurt reopened this Jan 27, 2020
@aaronhurt aaronhurt merged commit 13c6ab2 into master Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants