Fix matching priority for host:port tuples #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e566aaa reversed DNS names since they have their most significant part at the front. Unfortunately it didn't consider cases where the name is followed by a :port, making names without port always take precedence over names with a port. This patch changes the reverse function to ignores such port suffixes. Signed-off-by: Peter Schultz <peter.schultz@classmarkets.com>
|
Good catch. LGTM. Thank you! |
aaronhurt
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e566aaa reversed DNS names since they have
their most significant part at the front. Unfortunately it didn't
consider cases where the name is followed by a :port, making names
without port always take precedence over names with a port.
This patch changes the reverse function to ignores such port suffixes.
Closes #656