Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite buffering of SSE responses when gzip is enabled #739

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

ctlajoie
Copy link
Contributor

SSE requests (text/event-stream) don't work properly (no events are transmitted to the client) if proxy.gzip.contenttype is non-nil and gzip is in the Accept-Encoding header, because under those conditions the response gets chained through GzipResponseWriter even if no compression is being done. This change will bypass the GzipResponseWriter if there is a Accept: text/event-stream header.

@aaronhurt aaronhurt closed this Jan 27, 2020
@aaronhurt aaronhurt reopened this Jan 27, 2020
@aaronhurt
Copy link
Member

Triggering a rebuild now that Travis is functional again.

@aaronhurt aaronhurt merged commit 2e79b5a into fabiolb:master Jan 27, 2020
@aaronhurt
Copy link
Member

@ctlajoie Thank you! Sorry again for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants