Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating TLS cipher config parser to include TLS 1.3 constants. #904

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

nathanejohnson
Copy link
Member

fixes #903

minor update to build script

Copy link

@dmabry dmabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Pretty straight forward addition

Copy link

@dmabry dmabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

…903

minor update to build script

bump go version in github action

refactor to not hardcode TLS cipher suite constant name conversion, instead
call tls.CipherSuites() and tls.InsecureCipherSuites() to populate the map.
@nathanejohnson nathanejohnson force-pushed the feature/improve_tls_parser branch from 3b9c089 to 5910520 Compare September 13, 2022 18:12
Copy link

@dmabry dmabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. This is a better approach. Allowing future versions of Golang TLS additions to just work.

@nathanejohnson nathanejohnson merged commit 936832b into master Sep 13, 2022
@nathanejohnson nathanejohnson added this to the 1.6.3 milestone Sep 13, 2022
@tristanmorgan tristanmorgan deleted the feature/improve_tls_parser branch September 5, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update TLS cipher parser to include modern ciphers
2 participants