Add glob path matching (an alternative to default prefix matching) #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using "glob" matching, a backend server can register for "/foo.*" to handle routes such as "/foo.bar" and "/foo.bar.baz". The default option is still prefix matching (original behavior)
|
Interesting idea. This might solve a couple of other issues for people as well. Code looks clean on first glance and I like the integration. I'll spend a bit more time reviewing this but this looks like it is going in. Thanks for this. |
|
Looks good. I'll update the docs. |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a use case that requires being able to register a backend service with a glob style pattern
/foo.*and have it handle all routes such as/foo.bar,/foo.bar.baz, etc.This PR retains the original prefix matching behavior but adds an option to use glob matching. This also opens up the possibility to add regex matching down the line if it's useful.
Thanks.