Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think you may want to update your copy #1

Open
wants to merge 49 commits into
base: master
Choose a base branch
from

Conversation

robertkraig
Copy link

I think you may want these changes. You're copy is way out of date, and some reason my fork points to your copy now. @xDae no longer hosts this code.

fabiopaiva and others added 30 commits August 7, 2017 13:11
* Added support for video as file address

* suAdded support for multiple source files

* Added support for multiple source files
* Fixes #8 where it enables iconUrl option.

* Removed iconUrl from defaultProps

* Put back iconUrl in defaultProps and updated test snapshot.
* Fix key warning

* Bump patch version

* Add preload prop

* Add poster to sources version

* Bump patch version

* Add onLoadedData

* Refactor function

* Add className prop

* Fix test
* support audio

* add test for multiple sources

* react 16
* ⬆️ Bump plyr dependency to 3.2.1

* ✅ Update snapshots
xDae and others added 19 commits May 29, 2018 23:30
Unfortunately there was 1 line in defaultProps.js which was causing react-plyr to break our universal react app. I figured it would be safe to simply default to the captions language to `en` if it's ever ran server side.
* Return the player object onReady

I think it's an easy and also expected behaviour to return the player object in the onReady callback so users can access the API

* Revert "Return the player object onReady"

I think it's an expected behaviour to return the player object on the onReady callback - allows for easy access to the player's API
* SSR fix for error from referenced navigator

* Add setCurrentTime method
* add feature for captions to be added to a video

* can't use default as a key since it's a reserved key word

* use captions mapping in both return cases

* use "captions" as kind by default

* add test case for captions on video
* Bump Plyr version

3.3.21 > 3.4.8

* Readme - Props table
Available types for controls can be more than just an array of strings, it can be an actual markup set. https://github.com/sampotts/plyr/blob/master/controls.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.