-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I think you may want to update your copy #1
Open
robertkraig
wants to merge
49
commits into
fabiopaiva:master
Choose a base branch
from
robertkraig:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade yarn lock
* Added support for video as file address * suAdded support for multiple source files * Added support for multiple source files
* Fixes #8 where it enables iconUrl option. * Removed iconUrl from defaultProps * Put back iconUrl in defaultProps and updated test snapshot.
* Fix key warning * Bump patch version * Add preload prop * Add poster to sources version * Bump patch version * Add onLoadedData * Refactor function * Add className prop * Fix test
* support audio * add test for multiple sources * react 16
* ⬆️ Bump plyr dependency to 3.2.1 * ✅ Update snapshots
Unfortunately there was 1 line in defaultProps.js which was causing react-plyr to break our universal react app. I figured it would be safe to simply default to the captions language to `en` if it's ever ran server side.
* Return the player object onReady I think it's an easy and also expected behaviour to return the player object in the onReady callback so users can access the API * Revert "Return the player object onReady" I think it's an expected behaviour to return the player object on the onReady callback - allows for easy access to the player's API
* SSR fix for error from referenced navigator * Add setCurrentTime method
* add feature for captions to be added to a video * can't use default as a key since it's a reserved key word * use captions mapping in both return cases * use "captions" as kind by default * add test case for captions on video
* Bump Plyr version 3.3.21 > 3.4.8 * Readme - Props table
Available types for controls can be more than just an array of strings, it can be an actual markup set. https://github.com/sampotts/plyr/blob/master/controls.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think you may want these changes. You're copy is way out of date, and some reason my fork points to your copy now. @xDae no longer hosts this code.