Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventCache: Replaced property access to WeakMap access #423

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/events/helpers/get_events_cache.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// @require ./variables.ts

function getEventsCache ( ele: EleLoose ): { [event: string]: [string[], string, EventCallback][] } {

return ele[eventsNamespace] = ( ele[eventsNamespace] || {} );

let cache = eventsWeakMapCache.get( ele );
if ( !cache ) eventsWeakMapCache.set( ele, cache = {} );
return cache;
}
2 changes: 1 addition & 1 deletion src/events/helpers/variables.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

const eventsNamespace = '___ce';
const eventsWeakMapCache = new WeakMap ();
const eventsNamespacesSeparator = '.';
const eventsFocus: { [event: string]: string | undefined } = { focus: 'focusin', blur: 'focusout' };
const eventsHover: { [event: string]: string | undefined } = { mouseenter: 'mouseover', mouseleave: 'mouseout' };
Expand Down
1 change: 1 addition & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"compilerOptions": {
"lib": ["ES2015.Collection"],
"forceConsistentCasingInFileNames": true,
"noUnusedParameters": false,
"strictNullChecks": false
Expand Down