showFoundFiles should default to false

[ScrubN]

The setting showFoundFiles adds 30+ seconds of waiting for the extension to explore my entire user folder every time its used (on an NVMe), and includes many useless files such as NTUSER.DAT.

Please consider defaulting the setting to false. I seriously thought the extension was broken until I found the setting in the git history.

[fabiospampinato]

Is this repo public / do you know how I could reproduce the problem in some way?

It's possible we may be exploring directories that shouldn't be explored, 30s sounds insane for pretty much any repo 🤔

[ScrubN]

I'm not using vscode from within a cloned repo, I'm just launching it with the start menu. That probably sets the working directly to my user folder, which is is over 400GB in size.

I tried profiling the extension, however it didn't provide much useful information because the JS has been minified. I can, however, see that about 10% of the extension's CPU time is spent collecting garbage though.

Here are some ideas I have for improving the issue:

• Add a timeout to tiny-readdir-glob-gitignore (major)
• Do not run the file discoverer when in the user folder (major)
• Mutate state instead of making copies on hot paths in tiny-readdir-glob-gitignore (minor)
• Mutate state instead of making copies on hot paths in tiny-readdir-glob (minor)

[fabiospampinato]

Oh I see, it should be fairly easily fixable, I think if you are not inside a repo avoiding searching recursively makes sense, also somebody may still expect that to happen when working on an uninitialized repo 🤔 having some kind of limit, either in depth or number of files, makes sense also.

[ScrubN]

A depth limit of 1 or 2 when in an uninitialized repo sounds like a great idea. A file limit of around 10,000 also sounds like a good idea, but then you would end up with an imbalanced tree of discovered files and that would probably confuse users. Maybe that could be remedied by a notification alerting the user that the discovery limit was met, with buttons to the settings to increase it?

…

On Mon., Jul. 15, 2024, 6:05 p.m. Fabio Spampinato, < ***@***.***> wrote: Oh I see, it should be fairly easily fixable, I think if you are not inside a repo avoiding searching recursively makes sense, also somebody may still expect that to happen when working on an uninitialized repo 🤔 having some kind of limit, either in depth or number of files, makes sense also. — Reply to this email directly, view it on GitHub <#28 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARGBYQPKB3XCDFZXDYDOQALZMRBRZAVCNFSM6AAAAABK3U4OPOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRZGUYTOMBTHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[ScrubN]

Another idea is to add dotdirs to the exclude array by default. I don't think many users would be expecting to have their .vscode or .rustup directories appear as diff targets by default. On my machine, my dotdirs make up about 1/10 of the total files in my user directory.

[fabiospampinato]

That's interesting 🤔 A need to update the extension, but potentially if you put a .gitignore or .ignore file in there, to exclude those folders, the extension could respect that.