Use a queue to send SMS #96

Nainterceptor · 2019-12-19T14:19:19Z

Checklist

I've added a mention in CHANGELOG.md

Scttpr · 2019-12-19T14:22:43Z

.helm-chart/values.yaml

@@ -14,6 +14,7 @@ nameOverride: ""
 fullnameOverride: ""
 env:
  REDIS: e-chauffeur-redis
+  AMQP: rabbitmq.e-chauffeur


RabbitMQ and not AMQP ?

Scttpr · 2019-12-19T14:24:05Z

consumers/send-sms.js

+  }
+  container.on('message', async ({ message: { body: { body, to } } }) => {
+    if (!body || !to) {
+      return;


You don't log anything here ?

Scttpr · 2019-12-19T14:24:40Z

consumers/send-sms.js

+
+  const amqp = config.get('amqp');
+  if (!amqp) {
+    return;


You don't log anything here ?

Use a queue to send SMS

4574d30

Nainterceptor added the do not merge label Dec 19, 2019

Nainterceptor requested a review from Scttpr December 19, 2019 14:19

Scttpr reviewed Dec 19, 2019

View reviewed changes

consumers/send-sms.js

const amqp = config.get('amqp');

if (!amqp) {

return;

Copy link

Scttpr Dec 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't log anything here ?

Scttpr approved these changes Dec 19, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use a queue to send SMS #96

Use a queue to send SMS #96

Nainterceptor commented Dec 19, 2019

Scttpr Dec 19, 2019 •

edited

Loading

Scttpr Dec 19, 2019

Scttpr Dec 19, 2019

Use a queue to send SMS #96

Are you sure you want to change the base?

Use a queue to send SMS #96

Conversation

Nainterceptor commented Dec 19, 2019

Scttpr Dec 19, 2019 • edited Loading

Choose a reason for hiding this comment

Scttpr Dec 19, 2019

Choose a reason for hiding this comment

Scttpr Dec 19, 2019

Choose a reason for hiding this comment

Scttpr Dec 19, 2019 •

edited

Loading