Introduce RHEL based image #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riuvshin
pushed a commit
to openshiftio/openshiftio-cico-jobs
that referenced
this pull request
Apr 27, 2018
This was referenced Apr 27, 2018
jmelis
pushed a commit
to openshiftio/openshiftio-cico-jobs
that referenced
this pull request
Apr 27, 2018
added 2 commits
April 27, 2018 22:02
since RHEL parent image is in private repo we should login before docker build
jmelis
suggested changes
Apr 30, 2018
Makefile
Outdated
| REGISTRY := push.registry.devshift.net/osio-prod | ||
| else | ||
| DOCKERFILE := Dockerfile | ||
| REGISTRY := registry.devshift.net |
There was a problem hiding this comment.
REGISTRY sould be push.registry.devshift.net
There was a problem hiding this comment.
nice, catch! thanks
|
@riuvshin Your image is available in the registry: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable build on RHEL if TARGET=rhel.
The cico environment will continue to build the CentOS based container and in a second step it will build and push a RHEL based container.
cc: @jmelis @msrb @miteshvp