make DEPLOYMENTS_DIR overridable (#146) #147
Conversation
java/images/jboss/s2i/assemble
Outdated
| @@ -165,6 +165,7 @@ function build_maven() { | |||
|
|
|||
| echo "==================================================================" | |||
| echo "Starting S2I Java Build ....." | |||
| mkdir -p ${DEPLOYMENTS_DIR} | |||
There was a problem hiding this comment.
Could you please protect this like in
[ -d "${DEPLOYMENTS_DIR}" ] || mkdir -p "${DEPLOYMENTS_DIR}"
The reason is set if we should ever switch to set -e for a more strict error handling, then this would be already safe.
Also dont forget the quotes in case the directory name contains spaces.
There was a problem hiding this comment.
Of course, this comment should go to the original template source. you got the idea ;-)
vorburger
force-pushed
the
DEPLOYMENTS_DIR
branch
from
c05d2bb
to
be778c1
Compare
|
@rhuss have taken your feedback (hidden) above into account. PS: The original commit you commented on is actually already merged to master, probably because one of my other PRs you merged today had it as parent? (I've NOT pushed anything myself.) That's why only 1 commit is showing here now, with your suggested improvement to that. |
|
yeah, I rebased a lot yesterday and pushed it to your branches. no worries ;) |
No description provided.