Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start wait url does not support user information in URL #211

Closed
tdomzal opened this issue Jul 6, 2015 · 0 comments
Closed

Start wait url does not support user information in URL #211

tdomzal opened this issue Jul 6, 2015 · 0 comments

Comments

@tdomzal
Copy link
Contributor

tdomzal commented Jul 6, 2015

Currently wait option times out always when you try to refer to protected URL.
Specifying user auth info in URL does not make any difference.

I added some logging to HttpPingChecker and reason is http error 401:

...
[DEBUG] DOCKER> wait url 'http://user:pass@host/someurl' exception: Read timed out
[DEBUG] DOCKER> wait url 'http://user:pass@host/someurl' response code: 401
...

WaitUtil.HttpPingChecker uses java.net.HttpURLConnection and this is probable reason.

I think there are two options to allow user auth info:

  • use apache HttpClient lib which support user info by default (library is already in plugin depedencies).
  • keep using java.net.HttpURLConnection but:
    • extend configuration with authorization user / password (required configuration format change), or
    • extract auth info from specified url before using it.

I tested HttpClient option and can supply pull request for that.

rhuss added a commit that referenced this issue Jul 14, 2015
@rhuss rhuss closed this as completed in 8acf869 Jul 17, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant