Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the sledgehammer still exists during parallel execution runs #372

Closed
jgangemi opened this issue Feb 3, 2016 · 3 comments
Closed

the sledgehammer still exists during parallel execution runs #372

jgangemi opened this issue Feb 3, 2016 · 3 comments
Milestone

Comments

@jgangemi
Copy link
Collaborator

jgangemi commented Feb 3, 2016

if you run a reactor build in parallel, the plugin will stop any containers that get started during overall execution of the build.

@rhuss rhuss added the bug label Feb 14, 2016
@rhuss rhuss added this to the 0.14.0 milestone Feb 14, 2016
@rhuss rhuss added the fixed label Feb 14, 2016
rhuss added a commit that referenced this issue Feb 14, 2016
The ContainerTracker has been refactored to support PomLabels to only stop containerts stopped by a certain reactor project (identified via its Maven coordinates).
+ unit tests for container tracker.
@rhuss
Copy link
Collaborator

rhuss commented Feb 14, 2016

Thanks for your PR. I picked up the idea, however did the implementation slightly different (by moving the burden to filtering on PomLabel into the ContainerTracker). 'hope thats ok for you.

@jgangemi
Copy link
Collaborator Author

works for me - would it be possible to get a 0.13.9 release for this or is 0.14.0 a day or two away? this fix will allow me to finally switch over to running integration tests against containers at the day job.

rhuss added a commit that referenced this issue Feb 14, 2016
The ContainerTracker has been refactored to support PomLabels to only stop containerts stopped by a certain reactor project (identified via its Maven coordinates).
+ unit tests for container tracker.
@rhuss
Copy link
Collaborator

rhuss commented Feb 14, 2016

Just released 0.13.9 with this change only :) since I still need a bit for 0.14.0 (where we possible should present docker compose support already). Thanks for the initial PR and kicking the wire.

Also, I plan to move this repository to fabric8/docker-maven-plugin in order to join a larger community with some infrastructure already set up (mailing-list, IRC hannels). 'have to discuss this with our team still, though. Maybe 0.14.0 will be the first release there ;).

@rhuss rhuss closed this as completed Feb 14, 2016
rhuss added a commit that referenced this issue Feb 14, 2016
The ContainerTracker has been refactored to support PomLabels to only stop containerts stopped by a certain reactor project (identified via its Maven coordinates).
+ unit tests for container tracker.
rhuss added a commit that referenced this issue Feb 22, 2016
The ContainerTracker has been refactored to support PomLabels to only stop containerts stopped by a certain reactor project (identified via its Maven coordinates).
+ unit tests for container tracker.
rhuss added a commit that referenced this issue Nov 17, 2016
The ContainerTracker has been refactored to support PomLabels to only stop containerts stopped by a certain reactor project (identified via its Maven coordinates).
+ unit tests for container tracker.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants