Add multiline log matching #743
Conversation
This is related to fabric8io#628 and fabric8io#608 and should fix both issues. Also, some refactoring has been performed for the wait checkers which were extracted into an extra package.
| public boolean check() { | ||
| try { | ||
| return ping(); | ||
| } catch (IOException exception) { |
There was a problem hiding this comment.
Either log or rethrow this exception. 
|
|
||
| private WaitUtil() {} | ||
|
|
||
| public static long wait(int wait, Callable<Void> callable) throws ExecutionException, WaitTimeoutException { |
There was a problem hiding this comment.
Refactor this method to throw at most one checked exception instead of: java.util.concurrent.ExecutionException, io.fabric8.maven.docker.wait.WaitTimeoutException
| s.connect(address, TCP_PING_TIMEOUT); | ||
| s.close(); | ||
| iter.remove(); | ||
| } catch (IOException e) { |
There was a problem hiding this comment.
Either log or rethrow this exception.
| InetSocketAddress address = iter.next(); | ||
|
|
||
| try { | ||
| Socket s = new Socket(); |
There was a problem hiding this comment.
its closed short after that and its part of the test. wont fix
Codecov Report
@@ Coverage Diff @@
## master #743 +/- ##
============================================
+ Coverage 47.51% 47.89% +0.38%
- Complexity 1023 1041 +18
============================================
Files 126 130 +4
Lines 6699 6710 +11
Branches 872 872
============================================
+ Hits 3183 3214 +31
+ Misses 3244 3222 -22
- Partials 272 274 +2
Continue to review full report at Codecov.
|
|
SonarQube analysis reported 4 issues
Watch the comments in this conversation to review them. |
|
[merge] |
PR merged! Thanks!
This is related to #628 and #608 and should fix both issues.
Also, some refactoring has been performed for the wait checkers which were extracted into an extra package.