Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Added metadata visitors for imagestreams, build and buildconfig. #1449

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Added metadata visitors for imagestreams, build and buildconfig. #1449

merged 1 commit into from
Dec 11, 2018

Conversation

devang-gaur
Copy link
Contributor

Fixes #1425 .

@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

Merging #1449 into master will increase coverage by 0.03%.
The diff coverage is 37.5%.

@@             Coverage Diff              @@
##             master    #1449      +/-   ##
============================================
+ Coverage     34.85%   34.89%   +0.03%     
  Complexity     1046     1046              
============================================
  Files           171      171              
  Lines          9433     9448      +15     
  Branches       1612     1615       +3     
============================================
+ Hits           3288     3297       +9     
- Misses         5785     5791       +6     
  Partials        360      360

@codecov
Copy link

codecov bot commented Dec 11, 2018 •
edited
Loading

Codecov Report

Merging #1449 into master will increase coverage by <.01%.
The diff coverage is 37.5%.

@@             Coverage Diff              @@
##             master    #1449      +/-   ##
============================================
+ Coverage     34.85%   34.86%   +<.01%     
  Complexity     1046     1046              
============================================
  Files           171      171              
  Lines          9433     9448      +15     
  Branches       1612     1615       +3     
============================================
+ Hits           3288     3294       +6     
- Misses         5785     5794       +9     
  Partials        360      360

rhuss
rhuss approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rhuss rhuss merged commit 9ba4144 into fabric8io:master Dec 11, 2018
lordofthejars pushed a commit to lordofthejars/fabric8-maven-plugin that referenced this pull request Jan 17, 2019
@lordofthejars
Added metadata visitors for imagestreams, build and buildconfig. (fab…
90d2b75 
…ric8io#1449)
@rdruss rdruss mentioned this pull request Feb 28, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rhuss rhuss rhuss approved these changes

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@lordofthejars lordofthejars Awaiting requested review from lordofthejars

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devang-gaur @rhuss @rohanKanojia