Added support to choose configMap name

[h3nrique]

Fixes #1634

[rohanKanojia]

I don't think that is required.

[rohanKanojia]

strange, looking at code I think it should work. I would pull your branch and test on my machine.

[rohanKanojia]

Oops, a test is failing. Maybe that can give us an idea if we're missing something.

[h3nrique]

Strange.. I will check here.. Thanks

[h3nrique]

The error is in method ConfigMapEnricher.getConfigMapFromXmlConfiguration(), this method is not loading the configs for ConfigMap in tests scope. I've made a change that will not throws a NPE, the tests will pass now. :)

[codecov]

Codecov Report

Merging #1636 into master will decrease coverage by 0.03%.
The diff coverage is 12.5%.

@@             Coverage Diff              @@
##             master    #1636      +/-   ##
============================================
- Coverage     34.81%   34.77%   -0.04%     
  Complexity     1121     1121              
============================================
  Files           186      186              
  Lines         10309    10314       +5     
  Branches       1679     1680       +1     
============================================
- Hits           3589     3587       -2     
- Misses         6299     6305       +6     
- Partials        421      422       +1

[rohanKanojia]

@h3nrique : Works for me for this configuration:

                        <configMap>
                          <name>rohan-configmap</name>
                          <entries>
                            <entry>
                              <name>A</name>
                              <value>B</value>
                            </entry>
                           </entries>
                        </configMap>

What configuration were you trying for which it wasn't working? Could you please share?

[h3nrique]

@rohanKanojia I've identified that when uses variable (ex: ${project.artifactId}) the configmap It's not created.

I'm working in this here.

[rohanKanojia]

@lordofthejars : @paoloantinori is trying to create configmap using this configuration:

<configuration>
    <resources>
        <configMap>
            <name>${project.artifactId}</name>
            <entries>
                <entry>
                    <file>src/main/resources/application-openshift.properties</file>
                </entry>
            </entries>
        </configMap>
    </resources>
</configuration>

but it doesn't seem to be getting picked up. Could you please take a look into this if you have time? Is this configuration supported?

[rohanKanojia]

@h3nrique : Is it working now for you? for your application.properties use case?

[h3nrique]

Now It's working as well, I made a update that you say. Thanks.

[rohanKanojia]

@h3nrique : cool, can you please mark this draft ready for merge? I think we can merge it then 👍

[rohanKanojia]

@h3nrique : Sorry, I forgot to tell you. Could you please add a line to CHANGELOG.md regarding this?

[sleipnir]

Great this is exactly what I need