-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is KubernetesDeserializer in a package named "internal"? #1285
Comments
This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions! |
I think it won't be a problem if we move it out of internal package. |
This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions! |
This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions! |
@rohanKanojia can i work on this issue. I am not being able to understand such a huge codebase where to start from. |
Looking at this again - from the original motivation and typical usage with fabric8 it no longer needs to be moved. If you are using the dsl, there's no need to manually call registerCustomKind. The only reason you'd need to do that is if you are using deserialization routines independently of the dsl. |
You must use
KubernetesDeserializer.registerCustomKind
in order to successfully watchCustomResourceDefinitions
, as implemented inCRDExample
. Yet this type is in a package named "internal". Does this imply it shouldn't be used by library users? Should it be moved?The text was updated successfully, but these errors were encountered: