Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is KubernetesDeserializer in a package named "internal"? #1285

Closed
seglo opened this issue Dec 7, 2018 · 6 comments · Fixed by #3895
Closed

Why is KubernetesDeserializer in a package named "internal"? #1285

seglo opened this issue Dec 7, 2018 · 6 comments · Fixed by #3895

Comments

@seglo
Copy link

seglo commented Dec 7, 2018

You must use KubernetesDeserializer.registerCustomKind in order to successfully watch CustomResourceDefinitions, as implemented in CRDExample. Yet this type is in a package named "internal". Does this imply it shouldn't be used by library users? Should it be moved?

@stale
Copy link

stale bot commented Aug 6, 2019

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label Aug 6, 2019
@rohanKanojia
Copy link
Member

I think it won't be a problem if we move it out of internal package.

@stale stale bot removed the status/stale label Aug 6, 2019
@stale
Copy link

stale bot commented Nov 4, 2019

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale
Copy link

stale bot commented Feb 3, 2020

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@ps-19
Copy link
Contributor

ps-19 commented Oct 10, 2021

@rohanKanojia can i work on this issue. I am not being able to understand such a huge codebase where to start from.

@shawkins
Copy link
Contributor

Looking at this again - from the original motivation and typical usage with fabric8 it no longer needs to be moved. If you are using the dsl, there's no need to manually call registerCustomKind.

The only reason you'd need to do that is if you are using deserialization routines independently of the dsl.

shawkins added a commit to shawkins/kubernetes-client that referenced this issue Feb 24, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Feb 24, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Feb 24, 2022
@manusa manusa linked a pull request Mar 2, 2022 that will close this issue
11 tasks
manusa pushed a commit to shawkins/kubernetes-client that referenced this issue Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants