ValidatingWebhookConfigurationOperationsImpl should be a NonNamespaceOperation

[leogps]

When dealing with ValidatingWebhookConfiguration, namespace should not be specified in the url.
However, when creating a ValidatingWebhookConfiguration throws an exception as it ends up appending namespace to the url.

The following code constructs the URL incorrectly.

ValidatingWebhookConfiguration validatingWebhookConfiguration = new ValidatingWebhookConfiguration();
//.....
//.....
//.....
try(KubernetesClient kubernetesClient = new DefaultKubernetesClient(config)) {
            kubernetesClient
                    .resource(validatingWebhookConfiguration)
                    .createOrReplace();
}

Constructs:

https://:/apis/admissionregistration.k8s.io/v1beta1/namespaces/default/validatingwebhookconfigurations

Instead of:

https://:/apis/admissionregistration.k8s.io/v1beta1/validatingwebhookconfigurations

Reproducible with: kubernetes-client-4.1.2.jar

[rohanKanojia]

@leogps : Could you please create a quick PR to resolve this?

[rohanKanojia]

We need to add this method somehow, but it's autogenerated:

kubernetes-client/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/StorageClassOperationsImpl.java

Lines 38 to 41 in a33f01b

	@Override
	public boolean isResourceNamespaced() {
	return false;
	}

[leogps]

I see that the implementation makes use of jsonschema2pojo to auto-generate the pojos and seems like the Handler and the OperationImpl are also auto-generated. I am not sure how exactly this is accomplished.
Also, a git-blame on StorageClassOperationsImpl suggests that it was copied off of an auto-generated class.
Maybe, that is the way to go about this.

The ideal solution might be to fix the auto-generate logic to include the method properly.
Also isResourceNamespaced() doesn't suffice I guess. The checkNamespace() should be overridden to return null as OperationSupport#checkNamespace assumes a namespace and resolves to default even if the metadata does not include namespace.

[rohanKanojia]

@leogps : I think you're right. If we copy that class from target to dsl, and make changes onto it, it gets overridden. let me create a quick PR myself

[leogps]

Just checking if the fix is available in a newer build?

[rohanKanojia]

Yeah, you can verify via building snapshot from master मंगल, 26 मार्च 2019, 08:57 को leogps <notifications@github.com> ने लिखा:

…

Just checking if the fix is available in a newer build? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1387 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANMZAmiAVBI_gujXFaPxr3-oUrOTS0ixks5vaZOzgaJpZM4bgihX> .