More orphanDependents changes between 4.1.3 and 4.6.1

[k-wall]

Following on from #1775 which reported an API change in list().delete(), I notice other places where the semantics of the delete() have changed since 4.1.3.

Running this simple Main which calls client.configMaps().delete() with OkHttp tracing turned on:

against 4.1.3 I see:

INFO: {"apiVersion":"v1","kind":"DeleteOptions","orphanDependents":false}

against 4.6.1:

INFO: {"apiVersion":"v1","kind":"DeleteOptions","gracePeriodSeconds":0,"orphanDependents":true}

Bisecting, I see that the change was introduced in 4.2.0. Was this API change intentional? This will be breaking for existing users.

[rohanKanojia]

We changed deletion policy in order to align with kubectl defaults. I haven't checked for ConfigMap but isn't it the same when done using kubectl?

[k-wall]

Not for me. kubectl v1.14.1 sends Background which I believe corresponds to a cascading delete. This tallies with what I read.

$ kubectl -v=8 delete cm kwtest
I1029 14:10:48.323689   28292 loader.go:359] Config loaded from file /Users/keith/.kube/config
I1029 14:10:48.347667   28292 request.go:942] Request Body: {"propagationPolicy":"Background"}

If the intent was to change the API, it should be called out in the release notes. I don't think I see it.

[rohanKanojia]

@k-wall : ah, you're right. It's a mistake on our side that we haven't provided API change information in release notes. Apologies for that. I'll update the release note whenever I get time.

[k-wall]

Ok, our project will make a change to make explicit use of cascading(true) or withPropagationPolicy() so we get the behaviour it needs.

[k-wall]

@rohanKanojia from our perspective, this issue can be closed. We changed our code to adapt to the new behaviour.

[Aitozi]

Following on from #1775 which reported an API change in list().delete(), I notice other places where the semantics of the delete() have changed since 4.1.3.

Running this simple Main which calls client.configMaps().delete() with OkHttp tracing turned on:

against 4.1.3 I see:

INFO: {"apiVersion":"v1","kind":"DeleteOptions","orphanDependents":false}

against 4.6.1:

INFO: {"apiVersion":"v1","kind":"DeleteOptions","gracePeriodSeconds":0,"orphanDependents":true}

Bisecting, I see that the change was introduced in 4.2.0. Was this API change intentional? This will be breaking for existing users.

Hi, @k-wall I may have encountered the same issue, can you tell me how to enable the okhttp tracing log, thanks