Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BackwardCompatibilityInterceptor configureable #2716

Closed
lennartfricke opened this issue Jan 12, 2021 · 1 comment · Fixed by #2797 or jenkinsci/kubernetes-client-api-plugin#83
Closed
Assignees

Comments

@lennartfricke
Copy link

I've encounter problems similar to #2300 for deployments.
Accessing a non existing deployment does not result in "404 not found" but in permission denied,
mentioning extensions api group instead of apps. There is a role configured with access to apps/deployments
but not extensions/deployment.

I think the reason is the same as in #2300. The BackwardCompatibilityInterceptor converts the request to the
extension api group.

Maybe it would be good to document that behaviour more clearly and have an option to disable it.

@manusa
Copy link
Member

manusa commented Jan 18, 2021

We should at least add an option in the Configuration to disable the interceptor.

This would at least allow us to offer a workaround in case of future problems.

@rohanKanojia rohanKanojia self-assigned this Feb 8, 2021
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Feb 8, 2021
…terceptor

Added a flag "kubernetes.disable.backwardsCompatibilityInterceptor"
which will skip addition of BackwardCompatibilityInterceptor in
OkHttpClient created in HttpClientUtils.createHTTPClient
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Feb 9, 2021
…terceptor

Added a flag "kubernetes.disable.backwardsCompatibilityInterceptor"
which will skip addition of BackwardCompatibilityInterceptor in
OkHttpClient created in HttpClientUtils.createHTTPClient
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Feb 9, 2021
…terceptor

Added a flag "kubernetes.disable.backwardsCompatibilityInterceptor"
which will skip addition of BackwardCompatibilityInterceptor in
OkHttpClient created in HttpClientUtils.createHTTPClient
manusa pushed a commit to rohanKanojia/kubernetes-client that referenced this issue Feb 10, 2021
…terceptor

Added a flag "kubernetes.disable.backwardsCompatibilityInterceptor"
which will skip addition of BackwardCompatibilityInterceptor in
OkHttpClient created in HttpClientUtils.createHTTPClient
manusa pushed a commit that referenced this issue Feb 10, 2021
Added a flag "kubernetes.disable.backwardsCompatibilityInterceptor"
which will skip addition of BackwardCompatibilityInterceptor in
OkHttpClient created in HttpClientUtils.createHTTPClient
This was referenced Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment