KnativeClient.isSupported doesn't check all of the applicable API Groups

[manusa]

Describe the bug

Initially reported: quarkusio/quarkus#28171
With fix: quarkusio/quarkus#28172

The current implementation of isSupported() for KnativeClient is:

  public boolean isSupported() {
    return hasApiGroup("knative.dev", true);
  }

This is not taking into consideration all of the API groups our models support:

• serving.knative.dev
• flows.knative.dev
• networking.internal.knative.dev
• etc.

Fabric8 Kubernetes Client version

6.0.0

Steps to reproduce

• In a cluster with Knative CRDs, invoke the KnativeClient.isSupported method.
• false is returned instead of true

Expected behavior

true should be returned instead

Suggested fix

The check should not be exact:

  public boolean isSupported() {
    return hasApiGroup("knative.dev", false);
  }

[shawkins]

This change should be applied to DefaultServiceCatalogClient as well.

[rohanKanojia]

@shawkins : I'm not sure if I understand. From my understanding we only want to use hasApiGroup("<>", true) only when the client is dealing with model types that come from a single apiGroup. All resources in service-catalog module seem to be coming from servicecatalog.k8s.io apiGroup:

kubernetes-client/extensions/service-catalog/generator/cmd/generate/generate.go

Lines 57 to 59 in c134637

	packageMapping := map[string]schemagen.PackageInformation{
	"github.com/kubernetes-sigs/service-catalog/pkg/apis/servicecatalog/v1beta1": {JavaPackage: "io.fabric8.servicecatalog.api.model", ApiGroup: "servicecatalog.k8s.io", ApiVersion: "v1beta1"},
	}

Isn't it working as expected? Or perhaps I've misunderstood the problem.

[shawkins]

Isn't it working as expected? Or perhaps I've misunderstood the problem.

It is working as expected, but it's more restrictive that what the older check was. Since we don't guarantee a 1-1 relationship with api groups and clients, it's best to have these checks be more general. Should there be another sub group introduced, it will have the same problem as knative.