-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KubernetesResourceUtil issues #5220
Comments
Is it possible that these restrictions have changed in recent (mind the wording, meaning 1.14 or earlier) Kubernetes releases? |
None of what's mentioned in the description would be very recent, but yes it's entirely possible that the util methods were more applicable quite a long time ago. At this point I don't see a need to separate out rules by version, we'll start with just bringing things up-to-date and expanding the javadocs were needed. |
Neither do I. I was just curious about why were these rules implemented in the first place with wrong assumptions. The project's age seems to be taking a toll in some of our most foundational utilities. We (my team) might need to spend some time thoroughly reviewing those. |
This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions! |
The KubernetesResourceUtil methods related to resource names, labels, and annotations are not sufficiently documented or in some cases wrong. Resources names may be up to 253 characters, not just 63. Annotation and label keys name portion is limited to 63 chars, but they may contain a / separated prefix and with its own restrictions and the total character may be up to 253 characters long.
Annotation values are not restricted.
The text was updated successfully, but these errors were encountered: