Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1035 : RejectedExecutionException in WatchHTTPManager #1051

Merged
merged 1 commit into from
Apr 18, 2018
Merged

Fix #1035 : RejectedExecutionException in WatchHTTPManager #1051

merged 1 commit into from
Apr 18, 2018

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Apr 4, 2018 •
edited by piyush-garg
Loading

#1035

  • Added a check to avoid submitting task to executor if it's shutdown.

@piyush-garg
Copy link
Contributor

@rohanKanojia

It seems like if Added a check to avoid submitting task to executor if it's shutdown. is resolving the problem and working fine then we should keep it to log.info only as sometimes if it logs fetching breaks because of this reason it will be helpful for the users.

Please add this to changelog.md

Thanks

@rohanKanojia rohanKanojia force-pushed the issue1035 branch 2 times, most recently from 77493c3 to 409c9f2 Compare April 13, 2018 10:43
@piyush-garg
Copy link
Contributor

Looks good, Thanks for this @rohanKanojia

@rohanKanojia
Fix fabric8io#1035 : RejectedExecutionException in WatchHTTPManager
d3add2b 
+ Since RejectedExecutionException is a 'normal' situation that could
  happen in a healthy system. Move exception in reconnect stacktraces
  to logger.debug levels.
+ Added a check to avoid submitting task to executor if it's shutdown.
+ Updated CHANGELOG.md
@piyush-garg piyush-garg mentioned this pull request Apr 16, 2018
Closed
@piyush-garg
Copy link
Contributor

ok to test

1 similar comment
@rohanKanojia
Copy link
Member Author

ok to test

@piyush-garg
Copy link
Contributor

[merge]

@fusesource-ci fusesource-ci merged commit 5b1a57b into fabric8io:master Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-garg piyush-garg piyush-garg approved these changes

@iocanel iocanel Awaiting requested review from iocanel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohanKanojia @piyush-garg @fusesource-ci