Remove Test #1097
Merged
Remove Test #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrishin
approved these changes
Jun 12, 2018
|
This may be because of #1086 |
hrishin
reviewed
Jun 12, 2018
| @@ -201,6 +201,7 @@ private static String decodeUrl(String url) { | |||
| @Test | |||
| public void testWithServiceAccount() { | |||
| System.setProperty(Config.KUBERNETES_KUBECONFIG_FILE, "/dev/null"); | |||
| System.setProperty(Config.KUBERNETES_MASTER_SYSTEM_PROPERTY, "https://kubernetes.default.svc/"); | |||
There was a problem hiding this comment.
Here service account could return the different value hence assertion could vary from environment to environment.
To fix it, Its better way to have deterministic master URL value for SA or let be as this PR to temp fix.
There was a problem hiding this comment.
Since its blocking the release. Can we let it go and create another issue to fix this?
cc: @iocanel
If we keep that test, it will return different URl for every other CI. If we do some changes in test, it will be similar to other tests like setting masterUrl and all. This started happening after PR fabric8io#1086 Asserting not null and is URL is the only solution but does not make any difference as we have another tests for this func.
|
@Vlatombe Would you like to review and provide feedback for this? |
Vlatombe
approved these changes
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we keep that test, it will return different URl for
every other CI. If we do some changes in test, it will
be similar to other tests like setting masterUrl and all.
This started happening after PR #1086
Asserting not null and is URL is the only solution
but does not make any difference as we have another tests for this func.