-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1218: Add cascading() override to CustomResource #1325
Conversation
Can one of the admins verify this patch? |
From what I can tell the test failure is transient/environment related - can an admin please run them again?
|
ok to test |
@bfink13 : Yeah, you're right. I've restarted failed job :-) |
@bfink13 : Have you tested this PR with your own project or CRDExample? |
@rohanKanojia Yep! Just used this call: 4.1.1 gives me a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
[merge] |
Thanks @rohanKanojia - is there a release schedule somewhere? Or can you tell me when this will be released? |
@bfink13 : ah, right now we don't have any concrete release schedules. I usually release when I feel like enough issues or if there is urgent requirement from community side. I'm planning to release 4.1.2 in first week of february |
Great, thanks! |
Fixes #1218. I pretty much just emulated #1124.
This is my first PR, so let me know if I missed anything :)