Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1218: Add cascading() override to CustomResource #1325

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

bfink13
Copy link
Contributor

@bfink13 bfink13 commented Jan 23, 2019

Fixes #1218. I pretty much just emulated #1124.

This is my first PR, so let me know if I missed anything :)

@centos-ci
Copy link

Can one of the admins verify this patch?

@bfink13
Copy link
Contributor Author

bfink13 commented Jan 23, 2019

From what I can tell the test failure is transient/environment related - can an admin please run them again?

INFO: Deleting environment for io.fabric8.kubernetes.RoleBindingIT
[ERROR] Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.007 s <<< FAILURE! - in io.fabric8.kubernetes.RoleBindingIT
[ERROR] delete(io.fabric8.kubernetes.RoleBindingIT)  Time elapsed: 0.236 s  <<< FAILURE!
java.lang.AssertionError: expected:<0> but was:<1>
	at io.fabric8.kubernetes.RoleBindingIT.delete(RoleBindingIT.java:177)

@rohanKanojia
Copy link
Member

ok to test

@rohanKanojia
Copy link
Member

@bfink13 : Yeah, you're right. I've restarted failed job :-)

@rohanKanojia
Copy link
Member

@bfink13 : Have you tested this PR with your own project or CRDExample?

@rohanKanojia rohanKanojia added the needs code review Pull requests which are waiting for review label Jan 24, 2019
@bfink13
Copy link
Contributor Author

bfink13 commented Jan 24, 2019

@rohanKanojia Yep! Just used this call:
operation.inNamespace(resource.getMetadata().getNamespace()).withName(resource.getName()).cascading(true).delete();

4.1.1 gives me a NoSuchMethodException, 4.1-SNAPSHOT does not. I also confirmed cascading is being used downstream correctly (aka in the .delete() call).

Copy link
Member

@rohanKanojia rohanKanojia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rohanKanojia
Copy link
Member

[merge]

@rohanKanojia rohanKanojia removed the needs code review Pull requests which are waiting for review label Jan 25, 2019
@fusesource-ci fusesource-ci merged commit 780e3ee into fabric8io:master Jan 25, 2019
@bfink13
Copy link
Contributor Author

bfink13 commented Jan 25, 2019

Thanks @rohanKanojia - is there a release schedule somewhere? Or can you tell me when this will be released?

@rohanKanojia
Copy link
Member

rohanKanojia commented Jan 25, 2019

@bfink13 : ah, right now we don't have any concrete release schedules. I usually release when I feel like enough issues or if there is urgent requirement from community side. I'm planning to release 4.1.2 in first week of february

@bfink13
Copy link
Contributor Author

bfink13 commented Jan 25, 2019

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants