Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slash missing when client config from Config.loadFromKubeconfig #1329

Merged
merged 2 commits into from
Jan 25, 2019
Merged

Fix slash missing when client config from Config.loadFromKubeconfig #1329

merged 2 commits into from
Jan 25, 2019

Conversation

candyleer
Copy link
Contributor

@candyleer candyleer commented Jan 25, 2019 •
edited by rohanKanojia
Loading

Fixes #1309

@centos-ci
Copy link

Can one of the admins verify this patch?

@candyleer candyleer changed the title Fix slash omit when client config from loadFromKubeconfig Fix slash missing when client config from Config.loadFromKubeconfig Jan 25, 2019
@candyleer candyleer mentioned this pull request Jan 25, 2019
Closed
@oscerd
Copy link
Member

oscerd commented Jan 25, 2019

ok to test

@rohanKanojia
Copy link
Member

@candyleer : Thanks, Could you please add a line to CHANGELOG.md regarding this? I think we're good to merge this

@candyleer
Copy link
Contributor Author

@rohanKanojia ok, wait a moment

@candyleer
Copy link
Contributor Author

CHANGELOG has been added.BTW. do you have schedule to release 4.1.2?

@rohanKanojia
Copy link
Member

@candyleer : I'm planning to release in first week of February

rohanKanojia
rohanKanojia approved these changes Jan 25, 2019
View reviewed changes
Copy link
Member

@rohanKanojia rohanKanojia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@rohanKanojia
Copy link
Member

[merge]

@fusesource-ci fusesource-ci merged commit 8b3df4e into fabric8io:master Jan 25, 2019
@candyleer candyleer deleted the fix_version branch January 25, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@rohanKanojia rohanKanojia rohanKanojia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@candyleer @centos-ci @oscerd @rohanKanojia @fusesource-ci