Preserve labels and fields when using CRD's withResourceVersion() #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
oscerd
approved these changes
Mar 8, 2019
rohanKanojia
added
the
changelog missing
rohanKanojia
approved these changes
Mar 11, 2019
|
@xguerin: Could you please add a line to changelog also? I think we're good to merge. |
…ithResourceVersion
|
@rohanKanojia done. |
rohanKanojia
approved these changes
Mar 14, 2019
|
[merge] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation of
CustomResourceOperationsImpl::withResourceVersion()uses a constructor that discards any previous alterations made with operations such aswithLabel.This patch adds the necessary constructors in
BaseOperation,HasMetadataOperationandCustomResourceOperationsImplto allowwithResourceVersion()to preserve these fields.