feat: first draft of copy dsl for pods. #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@rohanKanojia: I managed to solve the issue that we were having. It seems that the root cause was that the exec command was failing silently and thus nothing was written in the streams. So, I removed the commit, with the experiments on the ExecWebSocketListener, timeouts etc, since it was not required for this to work. |
iocanel
changed the title
rohanKanojia
approved these changes
Mar 25, 2019
| @@ -15,6 +15,9 @@ | |||
| */ | |||
| package io.fabric8.kubernetes.client.dsl.internal; | |||
|
|
|||
| import java.io.File; | |||
| import java.io.FileNotFoundException; | |||
|
|
||
| private InputStream readFile(String source) throws Exception { | ||
| //Let's wrap the code to a callable inner class to avoid NoClassDef when loading this class. | ||
| try { |
There was a problem hiding this comment.
Can we use lambdas :-) here? Since we're already on Java 8...
| return new Callable<InputStream>() { | ||
| @Override | ||
| public InputStream call() throws Exception { | ||
| try { |
There was a problem hiding this comment.
Exception is never thrown in this block
|
|
||
| // | ||
| // | ||
| // The copy and read utilities below have been inspired by Brendan Burns copy utilities on the offical kubernetes-client. |
There was a problem hiding this comment.
typo s/offical/official
Did you mean this PR: kubernetes-client/java#375 ?
|
|
||
| import static junit.framework.TestCase.assertNotNull; | ||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.awaitility.Awaitility.await; | ||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertNull; |
rohanKanojia
added
the
changelog missing
iocanel
removed
the
changelog missing
|
[merge] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.