Adding support for using SubjectAccessReview #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
This is pr for #1455 |
|
ok to test |
oscerd
approved these changes
Mar 29, 2019
rohanKanojia
requested changes
Apr 1, 2019
kubernetes-client/src/main/java/io/fabric8/kubernetes/client/osgi/ManagedKubernetesClient.java
Outdated
Show resolved
Hide resolved
...ient/src/main/java/io/fabric8/kubernetes/client/dsl/internal/SubjectAccessReviewDSLImpl.java
Outdated
Show resolved
Hide resolved
...ient/src/main/java/io/fabric8/kubernetes/client/dsl/internal/SubjectAccessReviewDSLImpl.java
Show resolved
Hide resolved
rohanKanojia
added
the
changelog missing
|
@raiRaiyan : Could you please update CHANGELOG again resolving conflicts? |
rohanKanojia
reviewed
Apr 5, 2019
CHANGELOG.md
Outdated
| * Fix #1387: ValidatingWebhookConfigurationOperationsImpl should be a NonNamespaceOperation | ||
| * Fix #1429: Fixes JsonMappingException: No resource type found for:v1#List when reading a Kubernetes List YAML | ||
| * Fix #760: Api get pod from yaml issue | ||
| * Fix #807: Loading a deployment from server with a config file throws exception | ||
|
|
||
| Improvements | ||
|
|
||
| * Fix #1455: Use SubjectAccessReview and LocalSubjectAccessReview in kubernetes client using subjectAccessReviewAuth() |
There was a problem hiding this comment.
we released 4.2.0 last week, you have to move it above in 4.2-SNAPSHOT section.
added 4 commits
April 8, 2019 15:55
…view in kubernetes client
…, removing wildcard imports
rohanKanojia
removed
the
changelog missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for SubjectAccessReview and LocalSubjectAccessReview.
The openshift client already has support for
subjectAccessReviews, so I had named itsubjectAccessReviewAuthinKubernetesClient.