Fix #2107: Set PropagationPolicy to Background by default #2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Apr 29, 2020
|
retest this please |
rohanKanojia
force-pushed
the
pr/issue2107
branch
from
2d3dbae
to
9a4aefe
Compare
manusa
reviewed
Apr 30, 2020
kubernetes-client/src/main/java/io/fabric8/kubernetes/client/PropagationPolicyConfigurable.java
Outdated
Show resolved
Hide resolved
|
If propagation policy is a known set of values, why not use an enum instead? Only advantage of current implementation (free String) is that in the future k8s adds other valid values. But in that case, maybe some warning should be issued if the propagation policy is not within the accepted set, or at least create some publicly accessible constants. We want to prevent users who type |
rohanKanojia
force-pushed
the
pr/issue2107
branch
from
9a4aefe
to
d53a50a
Compare
rohanKanojia
force-pushed
the
pr/issue2107
branch
from
d53a50a
to
0036b67
Compare
manusa
reviewed
Apr 30, 2020
kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/base/OperationSupport.java
Outdated
Show resolved
Hide resolved
rohanKanojia
force-pushed
the
pr/issue2107
branch
from
0036b67
to
7fe8c83
Compare
|
SonarCloud Quality Gate failed.
|
|
[merge] |
aubinmora
added a commit
to aubinmora/kubernetes-plugin
that referenced
this pull request
Nov 22, 2023
follows fabric8io/kubernetes-client#2178 to use proper background cascading deletion preventing clients that cannot have access to finalizer to fail to create a pvc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2107
This should also take care of #2147