Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crd-gen] Respect JsonIgnore annotation on enum properties #4294

Merged
merged 1 commit into from
Aug 1, 2022
Merged

[crd-gen] Respect JsonIgnore annotation on enum properties #4294

merged 1 commit into from
Aug 1, 2022

Conversation

andreaTP
Copy link
Member

Description

Respect JsonIgnore on enum properties.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@andreaTP andreaTP requested a review from metacosm July 22, 2022 12:00
@andreaTP andreaTP mentioned this pull request Jul 22, 2022
Merged
11 tasks
@andreaTP andreaTP force-pushed the respect-json-ignore-enum-crd branch from f0f582f to a1f5042 Compare July 22, 2022 12:16
@andreaTP andreaTP force-pushed the respect-json-ignore-enum-crd branch from a1f5042 to b3009ae Compare July 25, 2022 10:37
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

57.7% 57.7% Coverage
0.0% 0.0% Duplication

@manusa manusa added this to the 6.1.0 milestone Aug 1, 2022
@manusa manusa merged commit bb99329 into fabric8io:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@oscerd oscerd oscerd approved these changes

@manusa manusa manusa approved these changes

@metacosm metacosm Awaiting requested review from metacosm

@iocanel iocanel Awaiting requested review from iocanel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@andreaTP @manusa @oscerd @rohanKanojia