fix #4637: adding a generalized ready timeout to pod operations #4695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #4637
Addresses #4637 - generalizes withLogWaitTimeout as withReadyWaitTimeout, which is applicable to all pod operations that require a ready (or succeeded pod). This uses the same paradigm of just setting the milliseconds - please comment if you want a different name, or the ability to specify the unit as we do with some of the other timeouts.
It also adds a validation to ensure that at least one of the streams is being used. This doesn't appear to be an issue with other clients as kubectl will always use stdin and python will default to using both stderr and stdout. I'm open as well to changing our default stream consumption behavior should we want to avoid this exception case.
Type of change
test, version modification, documentation, etc.)
Checklist