Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #4637: adding a generalized ready timeout to pod operations #4695

Merged
merged 2 commits into from
Dec 23, 2022

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Dec 19, 2022

Description

Fix #4637

Addresses #4637 - generalizes withLogWaitTimeout as withReadyWaitTimeout, which is applicable to all pod operations that require a ready (or succeeded pod). This uses the same paradigm of just setting the milliseconds - please comment if you want a different name, or the ability to specify the unit as we do with some of the other timeouts.

It also adds a validation to ensure that at least one of the streams is being used. This doesn't appear to be an issue with other clients as kubectl will always use stdin and python will default to using both stderr and stdout. I'm open as well to changing our default stream consumption behavior should we want to avoid this exception case.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

41.2% 41.2% Coverage
0.0% 0.0% Duplication

@manusa manusa added this to the 6.4.0 milestone Dec 23, 2022
@manusa manusa merged commit f63507c into fabric8io:master Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot run and attach a new pod that needs standard input
2 participants