Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(temp) Support for JsonTypeInfo annotations in UnmatchedFieldTypeModule #5028

Merged
merged 2 commits into from
Apr 5, 2023
Merged

(temp) Support for JsonTypeInfo annotations in UnmatchedFieldTypeModule #5028

merged 2 commits into from
Apr 5, 2023

Conversation

manusa
Copy link
Member

@manusa manusa commented Apr 5, 2023 •
edited
Loading

Description

Fix #5009

Temporary alternative to #5010 until Istio issues get fixed or gets superseded by #4662

Support for JsonTypeInfo annotations in UnmatchedFieldTypeModule

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa
fix: temp fix to support JsonTypeInfo annotations
01f2874 
Signed-off-by: Marc Nuri <marc@marcnuri.com>
@manusa manusa force-pushed the fix/untyped-module-inference branch from 26f69aa to 01f2874 Compare April 5, 2023 13:35
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@manusa
Copy link
Member Author

manusa commented Apr 5, 2023

@shawkins @metacosm merging this so it's baked into tonight's SNAPSHOTs.
Further changes can be provided in follow up PRs.

@manusa manusa added this to the 6.6.0 milestone Apr 5, 2023
@manusa manusa merged commit e2a85ad into fabric8io:master Apr 5, 2023
@manusa manusa deleted the fix/untyped-module-inference branch April 5, 2023 16:49
@shawkins shawkins mentioned this pull request Sep 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia

@shawkins shawkins Awaiting requested review from shawkins

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.6.0
Development

Successfully merging this pull request may close these issues.

Invalid serialization of wrapped polymorphic types
3 participants
@manusa @oscerd @shawkins