Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java-generator] handle more special characters in field names #5165

Merged
merged 1 commit into from
May 24, 2023
Merged

[java-generator] handle more special characters in field names #5165

merged 1 commit into from
May 24, 2023

Conversation

miriSch
Copy link
Contributor

@miriSch miriSch commented May 23, 2023 •
edited
Loading

Description

Fix #5164

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

andreaTP
andreaTP requested changes May 23, 2023
View reviewed changes
Copy link
Member

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR @miriSch ! Much appreciated!

I made one comment regarding performance, the rest looks good to me as soon as the CI is green 🙂

java-generator/core/src/main/java/io/fabric8/java/generator/nodes/AbstractJSONSchema2Pojo.java Outdated Show resolved Hide resolved
andreaTP
andreaTP requested changes May 23, 2023
View reviewed changes
Copy link
Member

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A last minor comment, thanks again!

java-generator/core/src/main/java/io/fabric8/java/generator/nodes/AbstractJSONSchema2Pojo.java Show resolved Hide resolved
andreaTP
andreaTP approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miriSch do you mind to solve the conflict and LGTM, thanks a lot!

@miriSch
Copy link
Contributor Author

miriSch commented May 24, 2023

@andreaTP conflict solved

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@andreaTP andreaTP merged commit b5091a8 into fabric8io:master May 24, 2023
@manusa manusa added this to the 6.7.0 milestone May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaTP andreaTP andreaTP approved these changes

@oscerd oscerd oscerd approved these changes

@manusa manusa Awaiting requested review from manusa

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia

@shawkins shawkins Awaiting requested review from shawkins

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.7.0
Development

Successfully merging this pull request may close these issues.

[java-generator] field names containing slashes lead to compile error
4 participants
@miriSch @oscerd @andreaTP @manusa