Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (kubernetes-client-api) : Support for using TokenRequest for existing ServiceAccount (#5133) #5249

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Jun 15, 2023

Description

Fix #5133

  • Add new DSL method tokenRequest() in ServiceAccount DSL which will request apiserver for token for the given ServiceAccount.
  • Since this TokenRequest isn't any standard resource but subresource for ServiceAccount, add ServiceAccountResource in order to add new TokenRequestable interface for ServiceAccount

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia rohanKanojia force-pushed the pr/issue5133-dsl branch 2 times, most recently from 9379d1e to 844d217 Compare June 15, 2023 11:21
…ken for ServiceAccount (fabric8io#5133)

+ Add new DSL method tokenRequest() which will request apiserver for
  token for the given ServiceAccount.
+ Since this TokenRequest isn't any standard resource but subresource
  for ServiceAccount, add ServiceAccountResource in order to add new
  TokenRequestable interface for ServiceAccount

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia marked this pull request as ready for review June 15, 2023 15:43
@manusa manusa added this to the 6.8.0 milestone Jun 16, 2023
Signed-off-by: Marc Nuri <marc@marcnuri.com>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

63.2% 63.2% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 8b7f467 into fabric8io:master Jun 16, 2023
@rohanKanojia rohanKanojia deleted the pr/issue5133-dsl branch June 16, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document a way how to use TokenRequest for existing ServiceAccount
3 participants