Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Chaos Test integration for SharedInformers #5276

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Initial Chaos Test integration for SharedInformers #5276

merged 2 commits into from
Sep 1, 2023

Conversation

andreaTP
Copy link
Member

Description

As promised in those tests we are running Chaos Mesh to verify that the SharedInformer successfully recovers after various network failures.

We did the negative test and those tests would have caught early issues like #5189

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

rohanKanojia
rohanKanojia reviewed Jun 23, 2023
View reviewed changes
chaos-tests/pom.xml Outdated Show resolved Hide resolved
rohanKanojia
rohanKanojia reviewed Jun 23, 2023
View reviewed changes
chaos-tests/pom.xml Outdated Show resolved Hide resolved
@andreaTP andreaTP mentioned this pull request Jun 27, 2023
Merged
17 tasks
@andreaTP andreaTP added this to the 6.8.0 milestone Jul 13, 2023
@sunix
Copy link
Collaborator

sunix commented Jul 17, 2023

Hey, are these tests been triggered somewhere in a github action ?

@andreaTP
Copy link
Member Author

@sunix only after we merge they are going to be triggered.

@sunix
Copy link
Collaborator

sunix commented Jul 17, 2023

@sunix only after we merge they are going to be triggered.

Yeah, I was just wondering if you had triggered it in your personal repo that we could see

@andreaTP
Copy link
Member Author

Yeah, I was just wondering if you had triggered it in your personal repo that we could see

My runs has been too old now, re-triggered:
https://github.com/andreaTP/kubernetes-client/actions/runs/5575025561

sunix
sunix reviewed Jul 18, 2023
View reviewed changes
chaos-tests/Readme.md Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@manusa
Copy link
Member

manusa commented Jul 19, 2023

I'll try to check/review the PR today.

@manusa manusa modified the milestones: 6.8.0, 6.9.0 Jul 24, 2023
@andreaTP
Copy link
Member Author

@manusa have you had a chance to review? Just rebased on latest main

@manusa
Copy link
Member

manusa commented Aug 31, 2023 •
edited
Loading

@manusa have you had a chance to review? Just rebased on latest main

Next in my queue

@manusa manusa self-assigned this Sep 1, 2023
@manusa
review: chaos-tests refinements
3ddfc67 
- consolidated Jar generation into a single maven-shade-plugin configuration
- optimized JKube configuration
- removed redundant plugin settings
- removed Pod template YAML files in favor of building programmatically
- moved global properties to main pom.xml

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@manusa manusa merged commit fe44c74 into fabric8io:main Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia left review comments

@sunix sunix sunix approved these changes

@manusa manusa manusa approved these changes

@oscerd oscerd Awaiting requested review from oscerd oscerd is a code owner

@shawkins shawkins Awaiting requested review from shawkins shawkins is a code owner

Assignees

@manusa manusa

Labels
None yet
Projects
None yet
Milestone
6.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@andreaTP @sunix @manusa @rohanKanojia