Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (extensions/tekton) : Clashing package names in trigger model dependencies (#5113) #5346

Merged
merged 1 commit into from
Jul 21, 2023
Merged

fix (extensions/tekton) : Clashing package names in trigger model dependencies (#5113) #5346

merged 1 commit into from
Jul 21, 2023

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Jul 20, 2023 •
edited
Loading

Description

Fix #5113

Remove knative duck classes from tekton triggers model

  • Both tekton-triggers-v1beta1 and tekton-triggers-v1alpha1 seem to be generating knative duck types that result in split package warning when both packages are used together. Use these packages from common knative-model dependency rather than generating it.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia
fix (extensions/tekton) : Remove knative duck classes from tekton tri…
11fbf29 
…ggers model (fabric8io#5113)

+ Both tekton-triggers-v1beta1 and tekton-triggers-v1alpha1 seem to be
  generating knative duck types that result in split package warning when
  both packages are used together. Use these packages from common
  knative-model dependency rather than generating it.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia marked this pull request as ready for review July 21, 2023 12:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@manusa manusa added this to the 6.8.0 milestone Jul 21, 2023
@manusa manusa merged commit efece3a into fabric8io:main Jul 21, 2023
@rohanKanojia rohanKanojia deleted the pr/issue5113 branch July 21, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@manusa manusa manusa approved these changes

@shawkins shawkins Awaiting requested review from shawkins shawkins is a code owner

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.8.0
Development

Successfully merging this pull request may close these issues.

Clashing package names in trigger model dependencies
3 participants
@rohanKanojia @manusa @oscerd