Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support for proxy authentication from proxy URL user info #6248

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

shawkins
Copy link
Contributor

Description

Uses authentication user info from proxy url.

This support will make it much easier for keycloak to work with a proxy. @manusa will there be another 6.13 release?

cc @Aboullos

closes: #6247

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

Copy link

@manusa
Copy link
Member

manusa commented Sep 17, 2024

This support will make it much easier for keycloak to work with a proxy. @manusa will there be another 6.13 release?

Sorry @shawkins, this PR got buried and I completely missed the notifications too :(

Regarding the 6.13 release, if it's required for you folks, then we can work it out.

closes: fabric8io#6247

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@shawkins
Copy link
Contributor Author

Sorry @shawkins, this PR got buried and I completely missed the notifications too :(

No problem, I should have checked in on it. Didn't notice it still needed attention until the other proxy issue. If we can get them both in to something that could get picked soon via quarkus that would be great.

@manusa manusa added this to the 7.0.0 milestone Sep 18, 2024 — with automated-tasks
Copy link

Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 8d8cd46 into fabric8io:main Sep 19, 2024
21 checks passed
@manusa manusa modified the milestones: 7.0.0, 6.13.4 Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxy urls should support inline credentials
3 participants