-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Canvas): allowTouchScrolling interactions #10078
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Build Stats
|
Needs playwright tests |
Hopefully this is a welcome improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current canvas.allowTouchScrolling doesn't really work.
close #5903
close #3869
close #9724
This PR changes the behaviour as follow:
allowTouchScrolling enabled set to true
Priority is given to enable scroll on canvas with touch event.
A touchStart event will not be prevented unless we are in drawing mode or we confirm the selection of an object.
If you are drawing, never scroll
if you select an object in this action, scroll
if you deselect the object, scroll
if you click the same object that was already selected, do not scroll.
If you want both touch scrolling and drag objects around, you will have to select with an event and drag the object with another event.
In a mobile device with allowTouchScrolling se to true multi selection by dragging won't work.
When the touchStart is NOT PREVENTED and so a scroll action start, the touch move events are ignore and won't trigger any canvas specific event.
Everything is let to the browser until touchUp fires
allowTouchScrolling disabled
Everything continue as normal