Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): Fix broken exports for filters that do not have a static defaults value. #10102

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

asturur
Copy link
Member

@asturur asturur commented Aug 29, 2024

Description

When refactoring filters recently i didn't think of possible filters that do not have needs for defaults values.
Those filters as today can't call the base filter export because the undefined static defaults will throw an error when converted to keys.

Copy link

codesandbox bot commented Aug 29, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link
Contributor

Build Stats

file / KB (diff) bundled minified
fabric 921.418 (+0.114) 306.781 (+0.004)

Copy link
Contributor

Coverage after merging fix-basic-filter-export into master will be

85.60%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
fabric.ts86.60%20%0%95.68%10, 139, 139, 139, 139, 139, 185, 185, 185, 185, 185, 31, 33, 33, 33, 33, 33–34, 34, 34, 34, 34, 39, 8
index.node.ts14.29%100%0%25%23, 26, 29, 41, 44, 47
extensions/aligning_guidelines/util
   basic.ts100%100%100%100%
extensions/data_updaters/origins
   index.ts97.50%75%100%100%22–23
src
   ClassRegistry.ts91.18%64.29%100%97.92%35, 56
   Collection.ts78.71%44.62%87.10%86.21%130, 153, 155–157, 159, 169–170, 181, 197, 217, 228, 241, 243, 252, 254, 265, 270, 279, 281, 286–287, 302, 304, 309–310, 329, 333–334, 338–344, 346–348, 350
   CommonMethods.ts91.43%71.43%100%96%50, 52
   EventTypeDefs.ts100%100%100%100%
   Intersection.ts85.25%48.91%100%97.30%184–188, 190, 228, 237, 239, 289, 297, 297
   Observable.ts80.63%53.49%93.75%87.88%144, 153, 156, 168, 170, 175, 68–70, 72, 76, 80, 84–85, 87–91
   Point.ts90.53%62%100%93.90%104, 117, 148, 157, 179, 197, 206, 216, 225, 236–239, 259, 285, 297, 328, 341, 349, 359, 95
   Shadow.ts89.21%78.26%100%90%140, 143, 145–150, 159, 196, 199, 206, 223–230, 234–235
   cache.ts84.88%45.45%100%90.14%57, 59, 71–72, 74–77
   config.ts87.73%55%66.67%94.03%132, 134–137, 139, 142–143, 147, 152
   constants.ts100%100%100%100%
   typedefs.ts100%100%100%100%
src/LayoutManager
   ActiveSelectionLayoutManager.ts93.33%76.92%85.71%100%
   LayoutManager.ts90.75%65.48%76.92%99.31%279, 344, 355
   constants.ts100%100%100%100%
   index.ts48.57%37.50%80%66.67%1, 1, 1–2, 2, 2–3, 3, 3–4, 4, 4–5, 5, 5, 5–6
   types.ts100%100%100%100%
src/LayoutManager/LayoutStrategies
   ClipPathLayout.ts75%56.25%100%78.95%39, 41–44, 46–48, 66–69
   FitContentLayout.ts100%100%100%100%
   FixedLayout.ts85.71%20%100%100%23, 23
   LayoutStrategy.ts87.60%57.14%100%96.51%46, 54, 73, 73, 75
   utils.ts72.58%50%100%78.72%29–32, 34–35, 40–44
src/Pattern
   Pattern.ts67.50%88.57%80%63.08%105–107, 114, 118–119, 119–122, 130–138, 140–141, 143, 153–164, 174, 176–181, 183–188, 190–199, 203–206, 209–210, 212–214, 216–218, 218–221, 33, 37
   index.ts50%100%100%50%2
   types.ts100%100%100%100%
src/brushes
   BaseBrush.ts89.33%91.67%100%88.55%110, 115, 124–125, 130, 135, 143, 146, 155–160, 99
   CircleBrush.ts52.10%12.50%12.50%58.25%100–108, 108–118, 122, 130–139, 55, 67, 69, 76, 76, 78–79, 79, 83, 85–86, 92–98
   PatternBrush.ts73.91%87.50%100%69.64%21, 25–31, 34, 36, 44, 54, 62, 64–67, 69
   PencilBrush.ts77.16%82.35%100%74.44%116, 122, 124, 129, 139, 147–149, 151–152, 152, 155, 158, 169, 176, 176, 181–184, 189, 191, 193–194, 198–201, 205, 215, 224–231, 235–236, 238, 246, 248, 255–256, 260–263, 266, 276, 278, 280–288, 296–297, 299, 68, 84
   SprayBrush.ts51.67%0%0%58.86%100, 107, 107, 107, 107, 107–112, 118–120, 122, 128–135, 137–139, 141, 141, 141–148, 148, 152, 157, 162, 164, 169–170, 172, 180, 182, 185, 187, 195, 198–200, 200, 200–207, 207, 207–210, 212, 22, 22, 67, 85–87, 94–99
   typedefs.ts100%100%100%100%
src/canvas
   Canvas.ts74.52%39.94%92.86%83.59%1000, 1005, 1009, 1013–1014, 1019, 1064–1069, 1106, 1127, 1131, 1138, 1141, 1204–1208, 1287–1291, 1318, 1335, 1381–1398, 1404–1409, 1412–1413, 1415, 1419, 1421–1422, 1424–1426, 1430, 1432, 1434–1436, 1439–1444, 1447–1449, 1452, 1454, 1468, 1475, 1477–1488, 1490–1493, 1493–1494, 1496–1497, 1501–1502, 1505–1506, 1509–1511, 1514, 329, 354, 370, 389, 444, 560–564, 567–568, 570, 580, 583–584, 586, 589–591, 603, 610–614, 616–621, 623–627, 660, 662, 669–673, 675–680, 682, 684–685, 687–690, 692–693, 748, 784–787, 790, 792, 795, 797, 799, 825, 834, 844, 846, 848–852, 855–862, 888, 933–934, 937, 939, 946, 949–954, 957, 965, 965–971, 973, 975, 996–997
   CanvasOptions.ts100%100%100%100%
   SelectableCanvas.ts85.44%54.08%100%94.39%1006, 1008–1009, 1026, 1035, 1103–1107, 1153–1154, 1156–1157, 1159, 1186, 1188–1189, 1189, 1191, 1233, 1235, 1237, 1253, 1255, 1283, 1286, 1329–1336, 1339, 1342, 1351–1352, 1356–1365, 1369, 1371–1372, 1378–1383, 1387, 340–342, 346, 376, 398, 476, 527, 529, 605, 610, 687, 715
   StaticCanvas.ts75.74%69.11%98.91%75.38%1000, 1006, 1009, 1011, 1013, 1021, 1023–1029, 1039, 1042,

@asturur asturur merged commit aa5b1c0 into master Aug 29, 2024
20 checks passed
@asturur asturur deleted the fix-basic-filter-export branch August 29, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant