Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): Use path instance context for exporting the path svg #10276

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Conversation

asturur
Copy link
Member

@asturur asturur commented Nov 15, 2024

Description

I was using the text instance to produce the svg export.
So colors and some common properties were coming from text

In Action

Copy link

codesandbox bot commented Nov 15, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link
Contributor

github-actions bot commented Nov 15, 2024

Code Coverage Summary

> fabric@5.4.1 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    83.4 |    77.39 |   86.25 |   83.12 |                                               
 fabric.js |    83.4 |    77.39 |   86.25 |   83.12 | ...,30577-30642,30765,30864,31083,31125-31127 
-----------|---------|----------|---------|---------|-----------------------------------------------

Copy link
Contributor

github-actions bot commented Nov 15, 2024

Code Coverage Summary

> fabric@5.4.1 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    83.4 |    77.39 |   86.25 |   83.12 |                                               
 fabric.js |    83.4 |    77.39 |   86.25 |   83.12 | ...,30577-30642,30765,30864,31083,31125-31127 
-----------|---------|----------|---------|---------|-----------------------------------------------

1 similar comment
Copy link
Contributor

github-actions bot commented Nov 15, 2024

Code Coverage Summary

> fabric@5.4.1 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    83.4 |    77.39 |   86.25 |   83.12 |                                               
 fabric.js |    83.4 |    77.39 |   86.25 |   83.12 | ...,30577-30642,30765,30864,31083,31125-31127 
-----------|---------|----------|---------|---------|-----------------------------------------------

Copy link
Contributor

github-actions bot commented Nov 15, 2024

Code Coverage Summary

> fabric@5.4.1 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    83.4 |    77.39 |   86.25 |   83.12 |                                               
 fabric.js |    83.4 |    77.39 |   86.25 |   83.12 | ...,30577-30642,30765,30864,31083,31125-31127 
-----------|---------|----------|---------|---------|-----------------------------------------------

@asturur asturur merged commit 335284c into 5.x Nov 15, 2024
11 checks passed
@asturur asturur deleted the v542-fix branch November 15, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants