Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include textBackgroundColor check in hasStyleChanged #8365

Merged
merged 2 commits into from
Oct 14, 2022
Merged

include textBackgroundColor check in hasStyleChanged #8365

merged 2 commits into from
Oct 14, 2022

Conversation

jakesjews
Copy link
Contributor

Prevent an undefined exception in stylesToArray when converting style objects which only contain a textBackgroundColor property

test/unit/text.js Outdated Show resolved Hide resolved
Copy link
Member

@melchiar melchiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@melchiar melchiar merged commit ab02461 into fabricjs:master Oct 14, 2022
melchiar added a commit that referenced this pull request Dec 2, 2022
frankrousseau pushed a commit to cgwire/fabric.js that referenced this pull request Jan 6, 2023
* include textBackgroundColor check in hasStyleChanged

* fix assert message and add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants