-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(TS): IText behavior mixins #8421
Conversation
Build stats are wrong
|
Tried my best for conflicts, let's see. |
28kb what? is that broken again? |
Updated description |
b94dff4 fixed the wrong stats |
2kb less 🥳 after minification! |
once #8421 is merged I will bind text events to IText
So we know that text mixins are messy. I don't think right now renaming classes/mixins/files is a good idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed
@ShaMan123 i ll start Static canvas today, and i look forward merging Image and observable types when we can. |
Yep. Started group. Will try to fix the failing test in Image. |
Motivation
Description
Continues #8420
This PR migrates IText mixins into classes that are chained to create the final IText class.
I have treated itext_behavior as the base class, holding more general methods, while itext_key_behavior and itext_click_behavior hold specific methods. itext_key_behavior is also in charge of the hidden textarea since it is part of the key behavior scope.
I moved some methods around to accommodate my approach but this is far from perfect.
I would rename the classes as well.
I have used abstract methods to make it easier to migrate the mixins. A follow up should do a heavier refactor, moving more methods and making the mixins more defined in scope.
Changes
Gist
Proto chain as follows:
In Action