Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port Registry I/O #8507

Closed
wants to merge 71 commits into from
Closed

port Registry I/O #8507

wants to merge 71 commits into from

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Dec 12, 2022 •
edited
Loading

Motivation

Description

ports what remains from #8282 to #8500

Changes

  • renamed: setClass to setJSONClass, getClass to getJSONClass
  • exposed setClass: register class to both JSON and SVG registeries
  • changed signature of getXXXClass accepting a strict param indicating if it should throw or not
  • use registry to resolve enlivenObjectEnlivenables
  • changed getJSONClass signature to accept an object, needed to resolve Gradient in enlivenObjectEnlivenables
  • refactored enlivenObjectEnlivenables to return an object only with enlived stuff, previously was returning everything
  • changed Gradient to fit the registry
  • enliven Shadow in enlivenObjectEnlivables not in set (I don't think it is breaking but devs can add type: shadow to data in case they fall into an edge case)
  • fix fromObject regression 3fd0660

Gist

closes #8282

In Action

asturur and others added 30 commits December 6, 2022 17:56
@asturur
some changes
751800c
@asturur
merge conflicts
310a84f
@asturur
some little work
6d298f4
@asturur
save work
736ab63
@asturur
removed namespace option
539cd8b
@asturur
forgot file
5d13e1c
@asturur
fixed class registry
9243ffb
@asturur
added specific test file
679ef2c
@asturur
removed camelize test
7dcddba
@asturur
no dist
00416f5
@asturur
made more similar to old getKlass
2e0f1fd
@asturur
changelog and prettier
dbe1077
@asturur
Merge branch 'master' into smaller-registry
1d5dbbb
@ShaMan123
refactor(): image fromObject
dc0cc0f
@ShaMan123
init
32cf22b
@ShaMan123
refactor registry + surrounding types
7d9d2d7
@ShaMan123
refactor canvas serialization
a7eddc4
@ShaMan123
unregister triangle
74f1a80
@ShaMan123
fix test
08cbcdb
@ShaMan123
Merge branch 'master' into smaller-registry-patch1
a8e5e51
@ShaMan123
Merge branch 'master' into smaller-registry
00a3a55
@ShaMan123
Merge branch 'smaller-registry' into smaller-registry-patch1
6da07a9
@ShaMan123
additional assertion
360d195
@ShaMan123
gradient from registry
fbd276a
@ShaMan123
cleanup
2cfb882
@ShaMan123
rename + consolidate registry setters
ec4ffde
@ShaMan123
add test
58b09e3
@ShaMan123
use constructor
4e6cb3c
@ShaMan123
Update image.class.ts
977f73f
@ShaMan123
Update class_registry.ts
09821b4
@ShaMan123 ShaMan123 requested a review from asturur February 13, 2023 05:39
ShaMan123
ShaMan123 commented Feb 19, 2023
View reviewed changes
Copy link
Contributor Author

@ShaMan123 ShaMan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

ShaMan123
ShaMan123 commented Mar 24, 2023
View reviewed changes
Copy link
Contributor Author

@ShaMan123 ShaMan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, resolved conflicts successfully I hope

@ShaMan123 ShaMan123 mentioned this pull request Apr 3, 2023
Merged
@fabricjs fabricjs deleted a comment from stale bot May 22, 2023
@ShaMan123
Copy link
Contributor Author

@asturur what about this??

@ShaMan123 ShaMan123 mentioned this pull request Jun 5, 2023
Closed
ShaMan123
ShaMan123 commented Aug 4, 2023
View reviewed changes
Copy link
Contributor Author

@ShaMan123 ShaMan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated from master and resolved conflicts

@ShaMan123 ShaMan123 mentioned this pull request Aug 4, 2023
Closed
@asturur asturur closed this Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asturur asturur Awaiting requested review from asturur

Assignees
No one assigned
Labels
fix-next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaMan123 @asturur