chore(TS) Remove small mixins that are too small to be worthy of existance

[asturur]

Motivation

Continue migration of TS

Description

Changes

• BREAKING: remove canvas.straightenObject
• BREAKING: cloneWithoutData clones only the size
• BREAKING: canvas.clone now correctly return either a canvas or staticCanvas
• 3 mixin file less.

Gist

In Action

[ShaMan123]

IMO canvas straightening belongs to animation
But actually we can dump it

[asturur]

all canvas animations are possibly dumped, are 4 premade animations that who needs them need probably more than 4 and can just make them

[github-actions]

Build Stats

file / KB (diff)	bundled	minified
fabric	956.032 (-2.947)	305.797 (-0.961)

[github-actions]

Coverage after merging remove-dataurl-mixin into master will be

82.79%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
HEADER.js	54%	48.15%	0%	63.64%	12, 14, 14, 14, 14, 14, 16–17, 21, 21–22, 22, 22, 24, 24, 26, 28, 30–31, 77, 77, 77
src
cache.ts	97.06%	90%	100%	100%	56
config.ts	77.27%	66.67%	66.67%	84.62%	130, 138–140, 151–153
constants.ts	100%	100%	100%	100%
intersection.class.ts	100%	100%	100%	100%
pattern.class.ts	92.31%	85.71%	100%	96.43%	120, 126, 137, 146, 98
point.class.ts	100%	100%	100%	100%
shadow.class.ts	98.51%	96%	100%	100%	157
src/brushes
base_brush.class.ts	100%	100%	100%	100%
circle_brush.class.ts	1.52%	0%	0%	2%	101, 103–105, 114, 114, 114, 116, 118, 120–122, 124–127, 135, 142, 144, 24, 29–30, 38–42, 46–50, 57–60, 68–72, 74, 82, 82, 82, 82, 82–83, 85, 85, 85–88, 90, 98–99
pattern_brush.class.ts	97.14%	87.50%	100%	100%	22
pencil_brush.class.ts	91.91%	85.42%	100%	93.64%	123–124, 153, 153–155, 277, 281, 286–287, 69–70, 85–86
spray_brush.class.ts	1.16%	0%	0%	1.56%	100–102, 104–105, 113, 113, 113, 113, 113–114, 116–117, 124–125, 127, 129–133, 142, 146–147, 147, 155, 155, 155–158, 160–163, 167–168, 170, 172–175, 178, 185–186, 188, 190–191, 193, 200–201, 203–204, 207, 207, 214, 214, 218, 23–24, 26–28, 28, 28–30, 34, 43, 50, 57, 64, 71, 78, 90–92
src/canvas
canvas.class.ts	92.52%	88.15%	94.12%	95.45%	1151, 1151–1152, 1155, 1175, 1175, 1237, 1273–1274, 1293–1294, 1302–1303, 1324, 1332, 1445–1446, 1448–1449, 1469–1470, 1633–1634, 1638, 510, 577–578, 583, 593, 722–723, 725–726, 726, 726, 772–773, 834–835, 838, 840, 885–887, 917, 922–923, 952–953
canvas_events.ts	78.10%	75%	82.81%	79.52%	1003–1004, 1004, 1004–1006, 1008–1009, 1009, 1009, 1011, 1019, 1019, 1019–1021, 1021, 1021, 1027–1028, 1036–1037, 1037, 1037–1038, 1043, 1045, 1075–1077, 1080–1081, 1085–1086, 1184, 1204–1206, 1209–1210, 1282, 1369, 1402, 145, 1496–1497, 1503, 1507–1508, 1524, 1546, 1593, 1598, 1637, 170, 318–319, 319, 319–320, 320, 323–327, 332, 334, 346–348, 351, 368, 368, 368–369, 369, 369–370, 378, 383–384, 384, 384–385, 387, 396, 402–403, 403, 403, 439, 443, 443, 443, 443, 443–444, 446, 521, 523, 523, 523–525, 545, 547, 547, 547–548, 548, 548, 551, 551, 551–552, 555, 564–565, 567–568, 570, 570–571, 573–574, 586–587, 587, 587–588, 590–594, 600, 607, 647, 647, 647, 649, 651–655, 661, 667, 667, 667–668, 670, 673, 678, 691, 718, 774–775, 775, 775–776, 778, 781–782, 782, 782–783, 785–786, 789, 789–791, 794–795, 805, 887, 901, 908, 929, 961, 982–983, 989
canvas_gestures.mixin.ts	9.21%	5.56%	7.14%	11.36%	101, 114, 127, 139, 148, 157–161, 170, 172, 172, 172–173, 175–176, 189, 198, 207, 211, 30, 30, 30–31, 31, 31, 31, 36, 39–40, 40, 40–41, 47, 50, 58, 58, 58, 58, 58–59, 62–64, 66–67, 69, 71, 71, 71–73, 76, 78, 88
static_canvas.class.ts	92.54%	85.99%	98.04%	95.27%	1132–1133, 1133, 1133–1134, 1254, 1264, 1318–1319, 1322, 1357–1358, 1436, 1445, 1450, 1565, 1567, 1569, 1569, 1569, 1569, 1572, 1572, 1572–1573, 1625–1627, 1629, 1631, 1631, 1631, 1631, 1635, 1635, 1635–1637, 1690–1691, 1919, 1919–1920, 1970, 1973, 1976, 1976, 1976, 1979, 1982, 1982, 1982, 315, 347, 360, 416–417, 419–420, 429, 433–434, 436–437, 806, 806–807, 892
src/color
color.class.ts	91.67%	84.51%	100%	94.44%	325–326, 330–331, 334–335, 41, 45, 72–73, 73, 75, 75, 75–76, 78–79
color_map.ts	100%	100%	100%	100%
constants.ts	100%	100%	100%	100%
index.ts	100%	100%	100%	100%
util.ts	100%	100%	100%	100%
src/controls
actions.ts	100%	100%	100%	100%
changeWidth.ts	100%	100%	100%	100%
control.class.ts	93.98%	88.89%	90.91%	97.78%	236, 320, 320, 355
controls.render.ts	81.63%	78%	100%	84.78%	106, 111, 121, 121, 45, 50, 61, 61, 65–72, 81–82
default_controls.ts	86.67%	66.67%	100%	100%	125, 132
drag.ts	100%	100%	100%	100%
rotate.ts	20%	12.50%	50%	22.22%	45, 51, 51, 51–52, 55–57, 59, 59, 59, 59, 59–61, 61, 61–63, 65, 65, 65–67, 67, 67–68,

[asturur]

removed straightenObject from canvas. Is not using any canvas property, is another:

objet.method() => method(object)

not worth anyone time

[asturur]

I think all the canvas animation can become functions that you can import to which you give a canvas and an object and you obtain an animaton.
Does not need to be on the instance, seems like something that was started and never really developed, and they look like more like 4 example animations to me
delete, bring to center ( x or y ), straighten

[ShaMan123]

I am for removing the animation mixin for good

[ShaMan123]

Suggested change

	return ['background', 'overlay']
	return (['background', 'overlay'] as const)

will type the array and remove the need for the extra as 'overlayColor' | backgroundColor

[ShaMan123]

6b10575

[ShaMan123]

see my comments

[ShaMan123]

you can do

new this.constructor(el)

Then it takes the instance class

[asturur]

tried already , is not happy about it. Neither with new this(el) nor with new this.contrsuctor(el).