feat(Object): pass ctx to dnd methods

[ShaMan123]

Description

Control over the context the dnd effects are drawn upon is vital for apps.
Also since we transform it beforehand it must be supplied

In Action

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

• Run Next Template
• Run Node Template
• Run Vanilla Template
• Run Vue Template

[github-actions]

Build Stats

file / KB (diff)	bundled	minified
fabric	918.407 (+1.535)	306.077 (+0.422)

[ShaMan123]

ready for review, please make this part of rc

[asturur]

The drag/drop effects are relatively new, if you want to swap the order of the arguments do it, but think first if to do an object or more paramters.
I tagged RC already but i don't mind is not a conceptual change this one

[asturur]

Either merge as is or re-check after param swapping

[ShaMan123]

I prefer param switching, do you think renderDrag.DropEffect should have ctx as first param as well?

[ShaMan123]

The drag/drop effects are relatively new, if you want to swap the order of the arguments do it, but think first if to do an object or more paramters. I tagged RC already but i don't mind is not a conceptual change this one

I missed this message. I want your opinion. I will change renderCursorAt and will wait for your call on the rest

[github-actions]

Coverage after merging chore/dnd-ctx into master will be

82.59%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
index.node.ts	14.29%	100%	0%	25%	23, 26, 29, 41, 44, 47
src
ClassRegistry.ts	88.71%	53.85%	100%	97.73%	31, 52, 52
Collection.ts	71.39%	31.15%	45.16%	83.91%	130, 138, 153, 155–157, 159, 169–170, 180–181, 197, 215, 217, 219, 228, 243, 254, 263, 265, 270, 279, 281, 283, 286–287, 302, 304, 306, 309–310, 327–328, 328, 328–329, 333–334, 337–344, 346–348, 350, 75, 99
CommonMethods.ts	85.51%	61.54%	66.67%	94%	50, 52, 61, 9
Intersection.ts	81.42%	41.30%	73.33%	96.14%	105, 132–133, 166, 184–190, 228, 228, 237, 239, 289–291, 297, 297, 78, 80
Observable.ts	71.20%	45.45%	31.25%	85.48%	136, 145, 148, 160, 162, 165, 167, 41, 43, 68–70, 72, 76, 78, 80, 82–85, 87–91
Point.ts	84.43%	61.22%	41.18%	92.38%	104, 117, 148, 157, 179, 197, 206, 216, 225, 236–239, 259, 284–285, 294–297, 317, 328, 341, 349, 359, 95
Shadow.ts	79.76%	17.39%	33.33%	88.37%	146–147, 147–150, 152–157, 166, 183, 183, 201, 201, 203–204, 204, 206, 213, 213, 230–237, 239, 239, 241–242, 38–41
cache.ts	83.72%	45.45%	75%	90.14%	57, 59, 71–72, 74–77
config.ts	82.21%	20%	44.44%	94.03%	123, 131–132, 134–137, 139, 142–143, 147, 152, 152, 152, 152, 152, 152
constants.ts	100%	100%	100%	100%
src/LayoutManager
ActiveSelectionLayoutManager.ts	86.67%	76.92%	28.57%	100%
LayoutManager.ts	89%	65.06%	53.85%	99.29%	269, 333, 344
constants.ts	100%	100%	100%	100%
index.ts	48.57%	37.50%	80%	66.67%	1, 1, 1–2, 2, 2–3, 3, 3–4, 4, 4–5, 5, 5, 5–6
types.ts	100%	100%	100%	100%
src/LayoutManager/LayoutStrategies
ClipPathLayout.ts	69.23%	33.33%	100%	78.95%	39, 41–42, 42–44, 46–48, 57, 57–58, 58, 66–69
FitContentLayout.ts	100%	100%	100%	100%
FixedLayout.ts	85.71%	20%	100%	100%	23, 23
LayoutStrategy.ts	86.78%	55.56%	71.43%	97.70%	54, 72, 74, 88
utils.ts	62.90%	7.14%	100%	78.72%	28–32, 34–35, 39, 39–44, 47, 47, 47
src/Pattern
Pattern.ts	54.39%	3.03%	10%	65.95%	105–107, 113, 113–114, 117, 117–119, 119, 119–122, 130, 130–132, 132, 132, 132, 132, 132–138, 140–141, 143, 150, 150, 150, 150, 153–160, 160, 160–164, 174–175, 175, 175, 175–176, 176, 176–182, 182, 182, 182–183, 183, 183–188, 190–199, 204–205, 207–209, 211, 33, 37
src/brushes
BaseBrush.ts	78.67%	8.33%	14.29%	88.55%	110, 114, 114–115, 122, 122, 122, 122, 124–125, 130, 135, 143, 146, 155, 155, 155, 155, 155–160, 99
CircleBrush.ts	52.10%	12.50%	12.50%	58.25%	100–108, 108–118, 122, 130–139, 55, 67, 69, 76, 76, 78–79, 79, 83, 85–86, 92–98
PatternBrush.ts	97.06%	87.50%	100%	100%	21
PencilBrush.ts	91.06%	82.35%	100%	93.81%	122–123, 152, 152–154, 176, 176, 276, 280, 285–286, 68–69, 84–85
SprayBrush.ts	0%	0%	0%	0%	107, 107, 107, 107, 107–108, 110–111, 118–119, 121, 123–127, 136, 140–141, 141, 148, 148, 148–151, 153–156, 160–161, 163, 165–168, 17, 171, 178–179, 18, 181, 183–184, 186, 193–194, 196–197, 20, 200, 200, 207, 207, 21, 211, 22, 22, 22–24, 28, 32, 39, 46, 53, 60, 67, 84–86, 94–96, 98–99
src/canvas
Canvas.ts	72.74%	30.88%	76.79%	84.67%	1004, 1008, 1012–1013, 1018, 1047, 1049, 1049, 1056, 1056, 1062–1068, 1074, 1105, 1126, 1130, 1137, 1140, 117, 1203–1207, 1241, 1260, 1286–1290, 1293, 1296, 1314, 1320, 1335, 1337, 1383–1404, 1406–1407, 1407–1411, 1414–1417, 1421–1424, 1426–1428, 1432, 1434, 1436–1438, 1441–1446, 1449–1451, 1454, 1456, 1470, 1477, 1479–1495, 1495, 1495, 1497, 1501–1502, 1505–1506, 1509–1511, 1514, 1522, 183, 318, 323, 343, 354, 369, 388, 431, 443, 559–563, 566–567, 569, 579, 582–583, 585, 588–590, 602, 609–613, 615–620, 622–626, 659, 661, 668–672, 674–679, 681, 683–684, 686–689, 691–692, 703, 747, 783–786, 789, 791, 791, 794, 796, 798, 824, 830, 839–840, 844, 867, 870, 870, 887, 906, 932–933, 936, 938, 948–953, 956, 964, 964–970, 972, 974, 994–996, 999
CanvasOptions.ts	100%	100%	100%	100%
SelectableCanvas.ts	83%	49.39%	80%	93.49%	1021, 1089–1093, 1139–1140, 1142–1143, 1145, 1172, 1174–1175, 1175, 1177, 1213, 1216, 1218, 1220, 1236, 1238, 1266, 1269, 1288, 1290,

[ShaMan123]

I heeded your advice after I understood #9850
Passing points and source/target make sense

[ShaMan123]

This is ready for another review
Done on my end

[asturur]

Please keep them separate.

My suggestion was saying that are probably multiple way to fix it this one seem the one with more code added.
It could be possible to just change scenePoint in something that is uncached and use the other cached value that doesn't change with the viewport.
That would be a 2 line change but we should check if it has impact in performance.

Also in this PR i think there is more that for the events? i see a prevTarget that seems new.

[ShaMan123]

I couldn't understand your comment
I passed prevDropTarget to _renderDragEffects to keep the code straightforward and supply better context for the API