Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding web options to hapi server #9

Closed
wants to merge 3 commits into from

Conversation

pmould
Copy link

@pmould pmould commented Nov 29, 2018

Description

Hapi Server Options set in web.options are not configured on server start up

Issues

lib/HapiSpool.ts Outdated
@@ -45,12 +45,13 @@ export class HapiSpool extends ServerSpool {
configure () {
this.app.config.set('web.server', 'hapi')
this.app.config.set('web.routes.files.relativeTo', this.app.config.get('main.paths.root'))
this.serverConfig = this.app.config.get('web.options');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might pass tests if you remove the semicolon

Copy link
Author

@pmould pmould Nov 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests are failing during the CI Build. The last PR was merged without CI running unit tests and then CI was turned on after I think

lib/HapiSpool.ts Outdated Show resolved Hide resolved
scott-wyatt added a commit that referenced this pull request Dec 3, 2018
@scott-wyatt scott-wyatt mentioned this pull request Dec 3, 2018
scott-wyatt added a commit that referenced this pull request Dec 3, 2018
@scott-wyatt scott-wyatt closed this Dec 3, 2018
@pmould pmould mentioned this pull request Dec 9, 2018
pmould pushed a commit to pmould/spool-hapi that referenced this pull request Dec 9, 2018
@scott-wyatt scott-wyatt mentioned this pull request Dec 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hapi Server Options set in web.options are not configured on server start up
2 participants