Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ImageButton CornerRadius type #37 #38

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Fix ImageButton CornerRadius type #37 #38

merged 2 commits into from
Jun 30, 2023

Conversation

kevkov
Copy link
Contributor

@kevkov kevkov commented Jun 29, 2023

No description provided.

@kevkov kevkov mentioned this pull request Jun 29, 2023
Closed
@TimLariviere
Copy link
Member

Thanks, that's good. 👍

Only one more thing to change I forgot about:

Fabulous.XamarinForms/docs/v2/apis/controls/image-button.md

Line 37 in 0514a6b

| cornerRadius(value: float) | Sets the corner radius |

It would be nice to update this documentation to match the new modifier signature.

TimLariviere
TimLariviere approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@TimLariviere TimLariviere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@TimLariviere TimLariviere merged commit 62d7930 into fabulous-dev:main Jun 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimLariviere TimLariviere TimLariviere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevkov @TimLariviere