Dispose properly ViewNode and Component when Widget is removed from tree #296
TimLariviereAnnotations
10 errors and 3 warnings
|
pull_request:
src/Fabulous.Tests/APISketchTests/TestUI.Attributes.fs#L21
The member or object constructor 'TryGetHandler' takes 0 type argument(s) but is here given 1. The required signature is 'abstract IViewNode.TryGetHandler: string -> IDisposable voption'.
|
|
pull_request:
src/Fabulous.Tests/APISketchTests/TestUI.Attributes.fs#L26
The type ''a voption' is not compatible with the type 'IDisposable'
|
|
pull_request:
src/Fabulous.Tests/APISketchTests/TestUI.Attributes.fs#L26
Type constraint mismatch. The type � ''a voption' �is not compatible with type� 'IDisposable'
|
|
pull_request:
src/Fabulous.Tests/APISketchTests/TestUI.Attributes.fs#L32
The member or object constructor 'SetHandler' takes 0 type argument(s) but is here given 1. The required signature is 'abstract IViewNode.SetHandler: string * IDisposable -> unit'.
|
|
pull_request:
src/Fabulous.Tests/APISketchTests/TestUI.Attributes.fs#L47
The member or object constructor 'TryGetHandler' takes 0 type argument(s) but is here given 1. The required signature is 'abstract IViewNode.TryGetHandler: string -> IDisposable voption'.
|
|
pull_request:
src/Fabulous.Tests/APISketchTests/TestUI.Attributes.fs#L52
The type ''a voption' is not compatible with the type 'IDisposable'
|
|
pull_request:
src/Fabulous.Tests/APISketchTests/TestUI.Attributes.fs#L52
Type constraint mismatch. The type � ''a voption' �is not compatible with type� 'IDisposable'
|
|
pull_request:
src/Fabulous.Tests/APISketchTests/TestUI.Attributes.fs#L58
The member or object constructor 'SetHandler' takes 0 type argument(s) but is here given 1. The required signature is 'abstract IViewNode.SetHandler: string * IDisposable -> unit'.
|
|
pull_request:
src/Fabulous.Tests/APISketchTests/TestUI.Attributes.fs#L73
The member or object constructor 'TryGetHandler' takes 0 type argument(s) but is here given 1. The required signature is 'abstract IViewNode.TryGetHandler: string -> IDisposable voption'.
|
|
pull_request:
src/Fabulous.Tests/APISketchTests/TestUI.Attributes.fs#L78
The type ''a voption' is not compatible with the type 'IDisposable'
|
|
pull_request
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-dotnet@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
pull_request:
src/Fabulous.Tests/APISketchTests/TestUI.Widgets.fs#L44
It is recommended that objects supporting the IDisposable interface are created using the syntax 'new Type(args)', rather than 'Type(args)' or 'Type' as a function value representing the constructor, to indicate that resources may be owned by the generated value
|
|
pull_request:
src/Fabulous.Tests/APISketchTests/TestUI.Widgets.fs#L44
It is recommended that objects supporting the IDisposable interface are created using the syntax 'new Type(args)', rather than 'Type(args)' or 'Type' as a function value representing the constructor, to indicate that resources may be owned by the generated value
|