Rework ViewElement to open new usages #809
Conversation
|
Introduced So this should have a great impact on the memory allocation due to the sheer numbers of |
| type ViewElementHolder(viewElement: ViewElement) = | ||
| let ev = new Event<_,_>() | ||
| type ViewElementHolder(viewElement: IViewElement, programDefinition: ProgramDefinition) = | ||
| let ev = Event<_,_>() |
There was a problem hiding this comment.
You might also want to populate this event object on-demand (mutable, null initially)
There was a problem hiding this comment.
Thanks. Will take a look if that's possible. Not sure if Xamarin.Forms expects PropertyChanged right after the creation.
src/Fabulous/IViewElement.fs
Outdated
| Trace: TraceLevel * string -> unit } | ||
|
|
||
| and IViewElement = | ||
| abstract Create: ProgramDefinition -> obj |
There was a problem hiding this comment.
I guess /// comments on each of these would be good :-) Given the central nature of the interface :)
There was a problem hiding this comment.
Yes, I'm planning to put /// comments on all public surface APIs.
src/Fabulous/Runner.fs
Outdated
| member x.SetDispatchThunk v = dispatchImpl <- v | ||
|
|
||
| /// Program type captures various aspects of program behavior | ||
| type RunnerDefinition<'arg, 'msg, 'model, 'externalMsg> = |
There was a problem hiding this comment.
TBH this should really have always been an interface I think. I made it a record out of deference to the Elmish/Elm origins
There was a problem hiding this comment.
The record did not bother me because it's easy to extend with optional and/or custom behaviors through Program.with....
An interface could do it too I guess, but might not be as simple to use.
I need to think about it.
|
@TimLariviere I love what you're doing here |
|
Thanks! |
|
This PR also reworks the way we print some debug info to the console, by using a built-in tracing tooling. |
TimLariviere
force-pushed
the
componentviewelement
branch
from
ec443e5
to
a82456d
Compare
TimLariviere
force-pushed
the
componentviewelement
branch
from
a82456d
to
aaeb9da
Compare
TimLariviere
force-pushed
the
componentviewelement
branch
from
0839cd5
to
9790f28
Compare
Runner + Tracing XF Program WIP Registrar/Handler AttachTarget/DetachTarget Fix ViewConverters/ViewUpdaters Fix CodeGen Fix CodeGen 2 Fix CodeGen 3 Working CounterApp & FabulousWeather samples Fix other samples except Shell AllControls ComponentViewElement Working external msg for component Fix merge Fix merge
TimLariviere
force-pushed
the
componentviewelement
branch
from
9222ddf
to
01a8be6
Compare
As part of the allocations reduction process, I'm reworking the
ViewElementclass to become an interfaceIViewElement.This will allow for different implementation such as
ComponentViewElement(see TimLariviere#25 for more information).In this example,
ComponentViewElementwould drastically reduce the number of allocated ViewElement at each update.